Allow the use of Literal in type annotation and use Enum in those cases #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 97.27% 97.66% +0.38%
==========================================
Files 24 24
Lines 1065 1070 +5
Branches 158 160 +2
==========================================
+ Hits 1036 1045 +9
+ Misses 14 12 -2
+ Partials 15 13 -2 |
|
@sccolbert do you want to have a look or can I proceeed with merging this ? |
MatthieuDartiailh
force-pushed
the
literal-support
branch
2 times, most recently
from
4aaff05 to
4250cc9
Compare
MatthieuDartiailh
force-pushed
the
literal-support
branch
from
4250cc9 to
0f6f4b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.