Use emplace instead of insert/push in ObserverPool::add

nucleic · Feb 1, 2025 · 8723c0b · 8723c0b
1 parent 0750392
commit 8723c0b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/atom/src/observerpool.cpp b/atom/src/observerpool.cpp
@@ -129,7 +129,7 @@ ObserverPool::add( cppy::ptr& topic, cppy::ptr& observer, uint8_t change_types )
             }
             if( obs_free == obs_end )
             {
-                m_observers.insert( obs_end, Observer( observer, change_types ) );
+                m_observers.emplace( obs_end, observer, change_types );
                 ++topic_it->m_count;
             }
             else
@@ -138,8 +138,8 @@ ObserverPool::add( cppy::ptr& topic, cppy::ptr& observer, uint8_t change_types )
         }
         obs_offset += topic_it->m_count;
     }
-    m_topics.push_back( Topic( topic, 1 ) );
-    m_observers.push_back( Observer(observer, change_types) );
+    m_topics.emplace_back( topic, 1 );
+    m_observers.emplace_back( observer, change_types );
 }