Define handlers with std::array

nucleic · Jan 22, 2025 · 6797be7 · 6797be7
1 parent 05967c0
commit 6797be7
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 28 deletions.
diff --git a/atom/src/defaultvaluebehavior.cpp b/atom/src/defaultvaluebehavior.cpp
@@ -187,8 +187,7 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, DefaultValue::Mode::Last> handlers = {
     no_op_handler,
     static_handler,
     list_handler,
@@ -205,7 +204,6 @@ handlers[] = {
     member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == DefaultValue::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/delattrbehavior.cpp b/atom/src/delattrbehavior.cpp
@@ -180,8 +180,7 @@ typedef int
 ( *handler )( Member* member, CAtom* atom );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, DelAttr::Mode::Last> handlers = {
     no_op_handler,
     slot_handler,
     constant_handler,
@@ -192,8 +191,6 @@ handlers[] = {
     property_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == DelAttr::Mode::Last, "Handler missing" );
-
 
 }  // namespace
 

diff --git a/atom/src/getattrbehavior.cpp b/atom/src/getattrbehavior.cpp
@@ -243,8 +243,7 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, GetAttr::Mode::Last> handlers = {
     no_op_handler,
     slot_handler,
     event_handler,
@@ -259,7 +258,6 @@ handlers[] = {
     member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == GetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/getstatebehavior.cpp b/atom/src/getstatebehavior.cpp
@@ -117,8 +117,7 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, GetState::Mode::Last> handlers = {
     include_handler,  // We want the include handler to be the default one
     exclude_handler,
     include_non_default_handler,
@@ -127,7 +126,6 @@ handlers[] = {
     member_method_object_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == GetState::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/member.h b/atom/src/member.h
@@ -7,6 +7,7 @@
 |----------------------------------------------------------------------------*/
 #pragma once
 
+#include <array>
 #include <vector>
 #include <cppy/cppy.h>
 #include "inttypes.h"

diff --git a/atom/src/postgetattrbehavior.cpp b/atom/src/postgetattrbehavior.cpp
@@ -87,16 +87,14 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom, PyObject* value );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, PostGetAttr::Mode::Last> handlers = {
     no_op_handler,
     delegate_handler,
     object_method_value_handler,
     object_method_name_value_handler,
     member_method_object_value_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == PostGetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/postsetattrbehavior.cpp b/atom/src/postsetattrbehavior.cpp
@@ -100,16 +100,14 @@ typedef int
 ( *handler )( Member* member, CAtom* atom, PyObject* oldvalue, PyObject* newvalue );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, PostSetAttr::Mode::Last> handlers = {
     no_op_handler,
     delegate_handler,
     object_method_old_new_handler,
     object_method_name_old_new_handler,
     member_method_object_old_new_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == PostSetAttr::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/postvalidatebehavior.cpp b/atom/src/postvalidatebehavior.cpp
@@ -91,16 +91,14 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom, PyObject* oldvalue, PyObject* newvalue );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, PostValidate::Mode::Last> handlers = {
     no_op_handler,
     delegate_handler,
     object_method_old_new_handler,
     object_method_name_old_new_handler,
     member_method_object_old_new_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == PostValidate::Mode::Last, "Handler missing" );
 
 }  // namespace
 

diff --git a/atom/src/setattrbehavior.cpp b/atom/src/setattrbehavior.cpp
@@ -363,8 +363,7 @@ typedef int
 ( *handler )( Member* member, CAtom* atom, PyObject* value );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, SetAttr::Mode::Last> handlers = {
     no_op_handler,
     slot_handler,
     constant_handler,
@@ -380,7 +379,6 @@ handlers[] = {
     member_method_object_value_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == SetAttr::Mode::Last, "Handler missing" );
 
 } // namespace
 

diff --git a/atom/src/validatebehavior.cpp b/atom/src/validatebehavior.cpp
@@ -964,8 +964,7 @@ typedef PyObject*
 ( *handler )( Member* member, CAtom* atom, PyObject* oldvalue, PyObject* newvalue );
 
 
-static handler
-handlers[] = {
+static const std::array<handler, Validate::Mode::Last> handlers = {
     no_op_handler,
     bool_handler,
     long_handler,
@@ -1000,7 +999,6 @@ handlers[] = {
     member_method_object_old_new_handler
 };
 
-static_assert( sizeof(handlers) / sizeof(handler) == Validate::Mode::Last, "Handler missing" );
 
 }  // namespace