Merge pull request #238 from frmdstryr/parse-mode-error

Return error if num args is incorrect in parse_mod_and_context
nucleic · Jan 21, 2025 · 338630c · 338630c
2 parents 54adc3f + caa2911
commit 338630c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/atom/src/member.cpp b/atom/src/member.cpp
@@ -458,7 +458,10 @@ parse_mode_and_context( PyObject*const *args, Py_ssize_t n, PyObject** context,
 {
 
     if( n != 2 )
+    {
+        cppy::type_error( "set mode requires two arguments mode, context" );
         return false;
+    }
     if( !EnumTypes::from_py_enum( args[0], mode ) )
         return false;
     *context = args[1];

diff --git a/tests/test_get_behaviors.py b/tests/test_get_behaviors.py
@@ -174,3 +174,12 @@ class SlotAtom(Atom):
 
     with pytest.raises(AttributeError):
         SlotAtom.v.do_getattr(sa)
+
+
+def test_using_invalid_args():
+    """Test using the invalid arguments."""
+    v = Value()
+    with pytest.raises(TypeError):
+        v.set_getattr_mode(None)
+    with pytest.raises(TypeError):
+        v.set_getattr_mode(7, None)