Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user specify ra,dec for fits input #333

Conversation

tsunhopang
Copy link
Collaborator

@mcoughlin Adding the missed functionality of letting user specify ra and dec in the prior file when using fits input

MAP iota prior with the gw170817.fits:
image

iota prior with ra = 3.44616, and dec = -0.408084:
image

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe should note somewhere the radian bit? Or specify somehow?

@tsunhopang
Copy link
Collaborator Author

It is input via the prior file, from which the ra and dec are always assumed to be radian (the same as in bilby)

@mcoughlin
Copy link
Member

Great thanks @tsunhopang

@tsunhopang tsunhopang merged commit 3b4a688 into nuclear-multimessenger-astronomy:main Mar 12, 2024
0 of 3 checks passed
@tsunhopang
Copy link
Collaborator Author

@bfhealy could you check of the failing test for training?

@bfhealy
Copy link
Collaborator

bfhealy commented Mar 13, 2024

@tsunhopang Sure, looks like it has something to do with this error:

TypeError: Could not locate function 'mse'. Make sure custom classes are decorated with `@keras.saving.register_keras_serializable()`. Full object config: {'module': 'keras.metrics', 'class_name': 'function', 'config': 'mse', 'registered_name': 'mse'}

I'll look into it some more, probably related to the recent tensorflow 2.16.1 release.

@bfhealy
Copy link
Collaborator

bfhealy commented Mar 13, 2024

@tsunhopang I propose to merge #334 to avoid this error for now. #335 is a reminder to refactor the code the address this more thoroughly in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants