Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bpf filter string for pfring_set_bpf_filter() unmutable. #943

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

utoni
Copy link
Contributor

@utoni utoni commented Jun 7, 2024

Please sign (check) the below before submitting the Pull Request:

Describe changes:

It's better to make the BPF string in pfring_set_bpf_filter() unmutable. It provides a potential developer an easy hint that it's contents won't change while calling that function.
During my PF_RING journey, I've found similar function's/callback's/typedef's that do not need mutable string's/buffer's.

@cardigliano cardigliano merged commit dca676a into ntop:dev Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants