Skip to content
This repository was archived by the owner on May 9, 2022. It is now read-only.

feat(rtc_types): add serialization helpers: byte_formats::rkyv_format #93

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

PiDelport
Copy link
Collaborator

@PiDelport PiDelport commented Jun 9, 2021

(Split from #87)

@PiDelport PiDelport added the feat New feature or request label Jun 9, 2021
@PiDelport PiDelport self-assigned this Jun 9, 2021
@PiDelport PiDelport force-pushed the feat-rkyv-binhelpers branch from 1a8d9f7 to 7e2cad3 Compare June 10, 2021 08:10
@PiDelport PiDelport force-pushed the feat-rkyv-binhelpers branch 3 times, most recently from c6eaf38 to 35edca6 Compare June 10, 2021 10:58
@PiDelport PiDelport marked this pull request as ready for review June 10, 2021 12:42
@PiDelport PiDelport requested review from longtomjr and Nghondzweni and removed request for longtomjr June 10, 2021 12:42
@PiDelport PiDelport changed the title feat: rkyv binhelpers feat(rtc_types): add serialization helpers: byte_formats::rkyv_format Jun 10, 2021
Copy link
Collaborator

@longtomjr longtomjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Just noted some minor subjective things, so feel free to merge as-is!

@PiDelport PiDelport force-pushed the feat-rkyv-binhelpers branch from 35edca6 to c7ea482 Compare June 10, 2021 16:54
@PiDelport PiDelport merged commit 73b91d4 into main Jun 10, 2021
@PiDelport PiDelport mentioned this pull request Jun 11, 2021
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants