This repository was archived by the owner on May 9, 2022. It is now read-only.
build: update dockerfile to use common base images #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiDelport
reviewed
Jul 16, 2021
| @@ -10,6 +10,12 @@ debug = false | |||
| lib_path = "/root/rtc-data/rtc_auth_enclave/build/bin/enclave.signed.so" | |||
| attestation_provider_url = "https://sharedeus.eus.attest.azure.net" | |||
|
|
|||
| [exec_enclave] | |||
| debug = false | |||
| # Relative to the binary | |||
There was a problem hiding this comment.
We could drop these "relative to" comments, if the paths are absolute?
Comment on lines
+7
to
+9
| cd rtc_data_enclave && make && cd .. | ||
| cd rtc_auth_enclave && make && cd .. | ||
| cd rtc_exec_enclave && make && cd .. |
There was a problem hiding this comment.
A bit easier and more idiomatic:
Suggested change
| cd rtc_data_enclave && make && cd .. | |
| cd rtc_auth_enclave && make && cd .. | |
| cd rtc_exec_enclave && make && cd .. | |
| (cd rtc_data_enclave && make) | |
| (cd rtc_auth_enclave && make) | |
| (cd rtc_exec_enclave && make) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.