clippy
21 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 21 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.73.0-nightly (08d00b40a 2023-08-09)
- cargo 1.73.0-nightly (d78bbf4bd 2023-08-03)
- clippy 0.1.73 (08d00b4 2023-08-09)
Annotations
Check warning on line 306 in src/router.rs
github-actions / clippy
this argument is a mutable reference, but not used mutably
warning: this argument is a mutable reference, but not used mutably
--> src/router.rs:306:17
|
306 | fn settle(link: &mut ReceiverLink, id: DeliveryNumber, state: DeliveryState) {
| ^^^^^^^^^^^^^^^^^ help: consider changing to: `&ReceiverLink`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
Check warning on line 161 in src/rcvlink.rs
github-actions / clippy
this argument is a mutable reference, but not used mutably
warning: this argument is a mutable reference, but not used mutably
--> src/rcvlink.rs:161:13
|
161 | cx: &mut Context<'_>,
| ^^^^^^^^^^^^^^^^ help: consider changing to: `&Context<'_>`
|
= warning: changing this function will impact semver compatibility
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default
Check warning on line 237 in src/router.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/router.rs:234:33
|
234 | / ... let _ = this.link.close_with_error(
235 | | ... LinkError::force_detach()
236 | | ... .description("delivery_id MUST be set"),
237 | | ... );
| |________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 225 in src/router.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/router.rs:223:33
|
223 | / ... let _ = this.link.close_with_error(
224 | | ... LinkError::force_detach().description(format!("error: {}", e)),
225 | | ... );
| |________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 380 in src/rcvlink.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/rcvlink.rs:380:21
|
380 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 369 in src/rcvlink.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/rcvlink.rs:369:25
|
369 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 340 in src/rcvlink.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/rcvlink.rs:340:25
|
340 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 327 in src/rcvlink.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/rcvlink.rs:327:25
|
327 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 309 in src/rcvlink.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/rcvlink.rs:309:13
|
309 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 418 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:418:13
|
418 | let _ = this.link.close_with_error(e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 230 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:230:13
|
230 | let _ = self.sink.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 223 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:223:13
|
223 | let _ = self.sink.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 139 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:139:21
|
139 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 136 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:136:21
|
136 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 131 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:131:21
|
131 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
Check warning on line 122 in src/dispatcher.rs
github-actions / clippy
non-binding `let` on a future
warning: non-binding `let` on a future
--> src/dispatcher.rs:122:21
|
122 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
Check warning on line 69 in src/dispatcher.rs
github-actions / clippy
this async expression only awaits a single future
warning: this async expression only awaits a single future
--> src/dispatcher.rs:69:36
|
69 | .push((frame, Box::pin(async move { fut.await })));
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `fut`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_async_block
= note: `#[warn(clippy::redundant_async_block)]` on by default
Check warning on line 533 in codec/src/codec/decode.rs
github-actions / clippy
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
--> codec/src/codec/decode.rs:533:13
|
533 | Utc.timestamp(seconds, nanoseconds as u32)
| ^^^^^^^^^
Check warning on line 530 in codec/src/codec/decode.rs
github-actions / clippy
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
--> codec/src/codec/decode.rs:530:13
|
530 | Utc.timestamp(seconds - 1, nanoseconds as u32)
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Check warning on line 169 in codec/src/types/variant.rs
github-actions / clippy
lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
--> codec/src/types/variant.rs:169:9
|
169 | #[allow(clippy::derive_hash_xor_eq)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
Check warning on line 9 in codec/src/message/mod.rs
github-actions / clippy
unnecessary `pub(self)`
warning: unnecessary `pub(self)`
--> codec/src/message/mod.rs:9:1
|
9 | pub(self) const SECTION_PREFIX_LENGTH: usize = 3;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default