Skip to content

Fix client connector usage, fixes lifetime constraint

Sign in for the full log view
GitHub Actions / clippy succeeded Aug 10, 2023 in 1s

clippy

25 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 25
Note 0
Help 0

Versions

  • rustc 1.73.0-nightly (08d00b40a 2023-08-09)
  • cargo 1.73.0-nightly (d78bbf4bd 2023-08-03)
  • clippy 0.1.73 (08d00b4 2023-08-09)

Annotations

Check warning on line 306 in src/router.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/router.rs:306:17
    |
306 | fn settle(link: &mut ReceiverLink, id: DeliveryNumber, state: DeliveryState) {
    |                 ^^^^^^^^^^^^^^^^^ help: consider changing to: `&ReceiverLink`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Check warning on line 161 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument is a mutable reference, but not used mutably

warning: this argument is a mutable reference, but not used mutably
   --> src/rcvlink.rs:161:13
    |
161 |         cx: &mut Context<'_>,
    |             ^^^^^^^^^^^^^^^^ help: consider changing to: `&Context<'_>`
    |
    = warning: changing this function will impact semver compatibility
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
    = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default

Check warning on line 237 in src/router.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/router.rs:234:33
    |
234 | / ...                   let _ = this.link.close_with_error(
235 | | ...                       LinkError::force_detach()
236 | | ...                           .description("delivery_id MUST be set"),
237 | | ...                   );
    | |________________________^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 225 in src/router.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/router.rs:223:33
    |
223 | / ...                   let _ = this.link.close_with_error(
224 | | ...                       LinkError::force_detach().description(format!("error: {}", e)),
225 | | ...                   );
    | |________________________^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 380 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/rcvlink.rs:380:21
    |
380 |                     let _ = self.close(Some(err));
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 369 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/rcvlink.rs:369:25
    |
369 |                         let _ = self.close(Some(err));
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 340 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/rcvlink.rs:340:25
    |
340 |                         let _ = self.close(Some(err));
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 327 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/rcvlink.rs:327:25
    |
327 |                         let _ = self.close(Some(err));
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 309 in src/rcvlink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/rcvlink.rs:309:13
    |
309 |             let _ = self.close(Some(err));
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 417 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:417:13
    |
417 |             let _ = this.link.close_with_error(e);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 231 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:231:13
    |
231 |             let _ = self.sink.close_with_error(err);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 224 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:224:13
    |
224 |             let _ = self.sink.close_with_error(err);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 140 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:140:21
    |
140 |                     let _ = link.close_with_error(err);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 137 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:137:21
    |
137 |                     let _ = link.close_with_error(err);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 132 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:132:21
    |
132 |                     let _ = link.close_with_error(err);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future

Check warning on line 123 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-binding `let` on a future

warning: non-binding `let` on a future
   --> src/dispatcher.rs:123:21
    |
123 |                     let _ = link.close_with_error(err);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider awaiting the future or dropping explicitly with `std::mem::drop`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
    = note: `#[warn(clippy::let_underscore_future)]` on by default

Check warning on line 250 in src/router.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead

warning: use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead
   --> src/router.rs:250:70
    |
250 | ...                   RouterServiceResponseState::Transfer(srv.service_call(tr), delivery_id);
    |                                                                ^^^^^^^^^^^^

Check warning on line 301 in src/dispatcher.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead

warning: use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead
   --> src/dispatcher.rs:301:47
    |
301 | ...                   fut: self.service.service_call(types::Message::Transfer(link)),
    |                                         ^^^^^^^^^^^^

Check warning on line 351 in src/server/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead

warning: use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead
   --> src/server/service.rs:351:18
    |
351 |                 .service_call(if protocol == ProtocolId::Amqp {
    |                  ^^^^^^^^^^^^

Check warning on line 213 in src/client/connector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead

warning: use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead
   --> src/client/connector.rs:213:14
    |
213 |             .service_call(Connect::new(addr))
    |              ^^^^^^^^^^^^

Check warning on line 170 in src/client/connector.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead

warning: use of deprecated method `ntex::Pipeline::<S>::service_call`: Use Pipeline::call() instead
   --> src/client/connector.rs:170:14
    |
170 |             .service_call(Connect::new(address))
    |              ^^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 533 in codec/src/codec/decode.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead

warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
   --> codec/src/codec/decode.rs:533:13
    |
533 |         Utc.timestamp(seconds, nanoseconds as u32)
    |             ^^^^^^^^^

Check warning on line 530 in codec/src/codec/decode.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead

warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
   --> codec/src/codec/decode.rs:530:13
    |
530 |         Utc.timestamp(seconds - 1, nanoseconds as u32)
    |             ^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

Check warning on line 169 in codec/src/types/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`

warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
   --> codec/src/types/variant.rs:169:9
    |
169 | #[allow(clippy::derive_hash_xor_eq)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
    |
    = note: `#[warn(renamed_and_removed_lints)]` on by default

Check warning on line 9 in codec/src/message/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary `pub(self)`

warning: unnecessary `pub(self)`
 --> codec/src/message/mod.rs:9:1
  |
9 | pub(self) const SECTION_PREFIX_LENGTH: usize = 3;
  | ^^^^^^^^^ help: remove it
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
  = note: `#[warn(clippy::needless_pub_self)]` on by default