Skip to content

clippy

clippy #293

Triggered via push October 9, 2023 07:36
Status Success
Total duration 13m 37s
Artifacts

windows.yml

on: push
Matrix: build_and_test
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 31 warnings
non-binding `let` on a future: src/router.rs#L234
error: non-binding `let` on a future --> src/router.rs:234:33 | 234 | / ... let _ = this.link.close_with_error( 235 | | ... LinkError::force_detach() 236 | | ... .description("delivery_id MUST be set"), 237 | | ... ); | |________________________^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/router.rs#L223
error: non-binding `let` on a future --> src/router.rs:223:33 | 223 | / ... let _ = this.link.close_with_error( 224 | | ... LinkError::force_detach().description(format!("error: {}", e)), 225 | | ... ); | |________________________^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/rcvlink.rs#L380
error: non-binding `let` on a future --> src/rcvlink.rs:380:21 | 380 | let _ = self.close(Some(err)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/rcvlink.rs#L369
error: non-binding `let` on a future --> src/rcvlink.rs:369:25 | 369 | let _ = self.close(Some(err)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/rcvlink.rs#L340
error: non-binding `let` on a future --> src/rcvlink.rs:340:25 | 340 | let _ = self.close(Some(err)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/rcvlink.rs#L327
error: non-binding `let` on a future --> src/rcvlink.rs:327:25 | 327 | let _ = self.close(Some(err)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/rcvlink.rs#L309
error: non-binding `let` on a future --> src/rcvlink.rs:309:13 | 309 | let _ = self.close(Some(err)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L416
error: non-binding `let` on a future --> src/dispatcher.rs:416:13 | 416 | let _ = this.link.close_with_error(e); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L228
error: non-binding `let` on a future --> src/dispatcher.rs:228:13 | 228 | let _ = self.sink.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L221
error: non-binding `let` on a future --> src/dispatcher.rs:221:13 | 221 | let _ = self.sink.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L137
error: non-binding `let` on a future --> src/dispatcher.rs:137:21 | 137 | let _ = link.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L134
error: non-binding `let` on a future --> src/dispatcher.rs:134:21 | 134 | let _ = link.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L129
error: non-binding `let` on a future --> src/dispatcher.rs:129:21 | 129 | let _ = link.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
non-binding `let` on a future: src/dispatcher.rs#L120
error: non-binding `let` on a future --> src/dispatcher.rs:120:21 | 120 | let _ = link.close_with_error(err); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future note: the lint level is defined here --> src/lib.rs:1:27 | 1 | #![deny(rust_2018_idioms, warnings, unreachable_pub)] | ^^^^^^^^ = note: `#[deny(clippy::let_underscore_future)]` implied by `#[deny(warnings)]`
lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`: codec/src/types/variant.rs#L169
warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` --> codec/src/types/variant.rs:169:9 | 169 | #[allow(clippy::derive_hash_xor_eq)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` | = note: `#[warn(renamed_and_removed_lints)]` on by default
stable - x86_64-pc-windows-msvc
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L676
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L676
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L679
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L679
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L689
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L689
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L692
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L692
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L748
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
stable - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L748
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
stable - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nightly - x86_64-pc-windows-msvc
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nightly - x86_64-pc-windows-msvc
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L676
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L676
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L679
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L679
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L689
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L689
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L692
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L692
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L748
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
nightly - x86_64-pc-windows-msvc: codec/src/codec/decode.rs#L748
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead