better readiness #291
wpbrownAnnotations
80 warnings
|
this argument is a mutable reference, but not used mutably:
src/router.rs#L311
warning: this argument is a mutable reference, but not used mutably
--> src/router.rs:311:17
|
311 | fn settle(link: &mut ReceiverLink, id: DeliveryNumber, state: DeliveryState) {
| ^^^^^^^^^^^^^^^^^ help: consider changing to: `&ReceiverLink`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
|
|
this argument is a mutable reference, but not used mutably:
src/rcvlink.rs#L161
warning: this argument is a mutable reference, but not used mutably
--> src/rcvlink.rs:161:13
|
161 | cx: &mut Context<'_>,
| ^^^^^^^^^^^^^^^^ help: consider changing to: `&Context<'_>`
|
= warning: changing this function will impact semver compatibility
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
= note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
src/session.rs#L501
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> src/session.rs:501:33
|
501 | handle: id as u32,
| ^^^^^^^^^ help: try: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
src/session.rs#L491
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> src/session.rs:491:33
|
491 | handle: id as u32,
| ^^^^^^^^^ help: try: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
non-binding `let` on a future:
src/router.rs#L238
warning: non-binding `let` on a future
--> src/router.rs:238:33
|
238 | / ... let _ = this.link.close_with_error(
239 | | ... LinkError::force_detach()
240 | | ... .description("delivery_id MUST be set"),
241 | | ... );
| |________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/router.rs#L227
warning: non-binding `let` on a future
--> src/router.rs:227:33
|
227 | / ... let _ = this.link.close_with_error(
228 | | ... LinkError::force_detach().description(format!("error: {}", e)),
229 | | ... );
| |________________________^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/rcvlink.rs#L380
warning: non-binding `let` on a future
--> src/rcvlink.rs:380:21
|
380 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/rcvlink.rs#L369
warning: non-binding `let` on a future
--> src/rcvlink.rs:369:25
|
369 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/rcvlink.rs#L340
warning: non-binding `let` on a future
--> src/rcvlink.rs:340:25
|
340 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/rcvlink.rs#L327
warning: non-binding `let` on a future
--> src/rcvlink.rs:327:25
|
327 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/rcvlink.rs#L309
warning: non-binding `let` on a future
--> src/rcvlink.rs:309:13
|
309 | let _ = self.close(Some(err));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
src/rcvlink.rs#L293
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> src/rcvlink.rs:293:28
|
293 | .rcv_link_flow(self.handle as u32, self.delivery_count, credit);
| ^^^^^^^^^^^^^^^^^^ help: try: `self.handle`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
non-binding `let` on a future:
src/dispatcher.rs#L417
warning: non-binding `let` on a future
--> src/dispatcher.rs:417:13
|
417 | let _ = this.link.close_with_error(e);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L358
warning: non-binding `let` on a future
--> src/dispatcher.rs:358:25
|
358 | let _ = self.service.call(types::Message::DetachedAll(receivers));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L344
warning: non-binding `let` on a future
--> src/dispatcher.rs:344:25
|
344 | let _ = self.service.call(types::Message::Detached(link));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L234
warning: non-binding `let` on a future
--> src/dispatcher.rs:234:13
|
234 | let _ = self.sink.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L149
warning: non-binding `let` on a future
--> src/dispatcher.rs:149:21
|
149 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L145
warning: non-binding `let` on a future
--> src/dispatcher.rs:145:21
|
145 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L142
warning: non-binding `let` on a future
--> src/dispatcher.rs:142:21
|
142 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L133
warning: non-binding `let` on a future
--> src/dispatcher.rs:133:21
|
133 | let _ = link.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
|
|
non-binding `let` on a future:
src/dispatcher.rs#L79
warning: non-binding `let` on a future
--> src/dispatcher.rs:79:13
|
79 | let _ = self.sink.close_with_error(err);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider awaiting the future or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future
= note: `#[warn(clippy::let_underscore_future)]` on by default
|
|
redundant field names in struct initialization:
src/session.rs#L685
warning: redundant field names in struct initialization
--> src/session.rs:685:29
|
685 | ... source: source,
| ^^^^^^^^^^^^^^ help: replace it with: `source`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
this `if` statement can be collapsed:
src/dispatcher.rs#L240
warning: this `if` statement can be collapsed
--> src/dispatcher.rs:240:9
|
240 | / if !self.ctl_queue.pending.borrow().is_empty() {
241 | | if ctl_service_poll.is_ready() {
242 | | while let Some(frame) = self.ctl_queue.pending.borrow_mut().pop_front() {
243 | | let detached_receiver = match frame.kind() {
... |
259 | | }
260 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
240 ~ if !self.ctl_queue.pending.borrow().is_empty() && ctl_service_poll.is_ready() {
241 + while let Some(frame) = self.ctl_queue.pending.borrow_mut().pop_front() {
242 + let detached_receiver = match frame.kind() {
243 + ControlFrameKind::LocalDetachReceiver(_, ref link) => Some(link.clone()),
244 + _ => None,
245 + };
246 + self.call_control_service(frame);
247 +
248 + if let Some(link) = detached_receiver {
249 + self.service.call(types::Message::Detached(link));
250 + }
251 +
252 + ctl_service_poll = self.poll_control_service_readiness(cx)?;
253 + if ctl_service_poll.is_pending() {
254 + break;
255 + }
256 + }
257 + control_fut_pending = true;
258 + }
|
|
|
deref on an immutable reference:
codec/src/types/mod.rs#L195
warning: deref on an immutable reference
--> codec/src/types/mod.rs:195:54
|
195 | Str::ByteStr(s) => write!(f, "B:\"{}\"", &*s),
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
195 | Str::ByteStr(s) => write!(f, "B:\"{}\"", s),
| ~
help: if you would like to deref, try using `&**`
|
195 | Str::ByteStr(s) => write!(f, "B:\"{}\"", &**s),
| ~~~~
|
|
deref on an immutable reference:
codec/src/types/mod.rs#L183
warning: deref on an immutable reference
--> codec/src/types/mod.rs:183:31
|
183 | let t: &str = &*s;
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
183 | let t: &str = s;
| ~
help: if you would like to deref, try using `&**`
|
183 | let t: &str = &**s;
| ~~~~
|
|
this expression borrows a value the compiler would automatically borrow:
codec/src/types/mod.rs#L143
warning: this expression borrows a value the compiler would automatically borrow
--> codec/src/types/mod.rs:143:32
|
143 | Str::ByteStr(s) => (&*s).hash(state),
| ^^^^^ help: change this to: `(*s)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
deref on an immutable reference:
codec/src/types/mod.rs#L143
warning: deref on an immutable reference
--> codec/src/types/mod.rs:143:32
|
143 | Str::ByteStr(s) => (&*s).hash(state),
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
143 | Str::ByteStr(s) => s.hash(state),
| ~
help: if you would like to deref, try using `&**`
|
143 | Str::ByteStr(s) => &**s.hash(state),
| ~~~~
|
|
this expression borrows a value the compiler would automatically borrow:
codec/src/types/mod.rs#L142
warning: this expression borrows a value the compiler would automatically borrow
--> codec/src/types/mod.rs:142:31
|
142 | Str::String(s) => (&*s).hash(state),
| ^^^^^ help: change this to: `(*s)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
deref on an immutable reference:
codec/src/types/mod.rs#L142
warning: deref on an immutable reference
--> codec/src/types/mod.rs:142:31
|
142 | Str::String(s) => (&*s).hash(state),
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
142 | Str::String(s) => s.hash(state),
| ~
help: if you would like to deref, try using `&**`
|
142 | Str::String(s) => &**s.hash(state),
| ~~~~
|
|
casting to the same type is unnecessary (`i64` -> `i64`):
codec/src/types/variant.rs#L143
warning: casting to the same type is unnecessary (`i64` -> `i64`)
--> codec/src/types/variant.rs:143:38
|
143 | Variant::Long(v) => Some(*v as i64),
| ^^^^^^^^^ help: try: `*v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`i32` -> `i32`):
codec/src/types/variant.rs#L129
warning: casting to the same type is unnecessary (`i32` -> `i32`)
--> codec/src/types/variant.rs:129:37
|
129 | Variant::Int(v) => Some(*v as i32),
| ^^^^^^^^^ help: try: `*v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
this `impl` can be derived:
codec/src/protocol/mod.rs#L308
warning: this `impl` can be derived
--> codec/src/protocol/mod.rs:308:1
|
308 | / impl Default for ReceiverSettleMode {
309 | | fn default() -> ReceiverSettleMode {
310 | | ReceiverSettleMode::First
311 | | }
312 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
--> codec/src/protocol/definitions.rs:499:1
|
499 + #[derive(Default)]
500 | pub enum ReceiverSettleMode {
|
help: ...and mark the default variant
--> codec/src/protocol/definitions.rs:500:5
|
500 ~ #[default]
501 ~ First,
|
|
|
this `impl` can be derived:
codec/src/protocol/mod.rs#L302
warning: this `impl` can be derived
--> codec/src/protocol/mod.rs:302:1
|
302 | / impl Default for SenderSettleMode {
303 | | fn default() -> SenderSettleMode {
304 | | SenderSettleMode::Mixed
305 | | }
306 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
--> codec/src/protocol/definitions.rs:443:1
|
443 + #[derive(Default)]
444 | pub enum SenderSettleMode {
|
help: ...and mark the default variant
--> codec/src/protocol/definitions.rs:446:5
|
446 ~ #[default]
447 ~ Mixed,
|
|
|
this `impl` can be derived:
codec/src/protocol/mod.rs#L296
warning: this `impl` can be derived
--> codec/src/protocol/mod.rs:296:1
|
296 | / impl Default for Role {
297 | | fn default() -> Role {
298 | | Role::Sender
299 | | }
300 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
--> codec/src/protocol/definitions.rs:397:1
|
397 + #[derive(Default)]
398 | pub enum Role {
|
help: ...and mark the default variant
--> codec/src/protocol/definitions.rs:398:5
|
398 ~ #[default]
399 ~ Sender,
|
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L3247
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:3247:23
|
3247 | DetachBuilder(Box::new(DetachInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L3016
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:3016:28
|
3016 | DispositionBuilder(Box::new(DispositionInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L2642
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:2642:25
|
2642 | TransferBuilder(Box::new(TransferInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L2274
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:2274:21
|
2274 | FlowBuilder(Box::new(FlowInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L1834
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:1834:23
|
1834 | AttachBuilder(Box::new(AttachInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L1537
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:1537:22
|
1537 | BeginBuilder(Box::new(BeginInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L1199
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:1199:21
|
1199 | OpenBuilder(Box::new(OpenInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
|
|
`Box::new(_)` of default value:
codec/src/protocol/definitions.rs#L1036
warning: `Box::new(_)` of default value
--> codec/src/protocol/definitions.rs:1036:22
|
1036 | ErrorBuilder(Box::new(ErrorInner::default()))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `#[warn(clippy::box_default)]` on by default
|
|
casting the result of `i64::abs()` to u32:
codec/src/codec/decode.rs#L532
warning: casting the result of `i64::abs()` to u32
--> codec/src/codec/decode.rs:532:27
|
532 | let nanoseconds = ((millis - (seconds * 1000)) * 1_000_000).abs() as u32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `((millis - (seconds * 1000)) * 1_000_000).unsigned_abs()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned
|
|
casting the result of `i64::abs()` to u32:
codec/src/codec/decode.rs#L529
warning: casting the result of `i64::abs()` to u32
--> codec/src/codec/decode.rs:529:27
|
529 | let nanoseconds = ((1000 + (millis - (seconds * 1000))) * 1_000_000).abs() as u32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `((1000 + (millis - (seconds * 1000))) * 1_000_000).unsigned_abs()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned
= note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default
|
|
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead:
codec/src/codec/decode.rs#L533
warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
--> codec/src/codec/decode.rs:533:13
|
533 | Utc.timestamp(seconds, nanoseconds)
| ^^^^^^^^^
|
|
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead:
codec/src/codec/decode.rs#L530
warning: use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
--> codec/src/codec/decode.rs:530:13
|
530 | Utc.timestamp(seconds - 1, nanoseconds)
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`:
codec/src/types/variant.rs#L169
warning: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`
--> codec/src/types/variant.rs:169:9
|
169 | #[allow(clippy::derive_hash_xor_eq)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
|
|
unnecessary `pub(self)`:
codec/src/message/mod.rs#L9
warning: unnecessary `pub(self)`
--> codec/src/message/mod.rs:9:1
|
9 | pub(self) const SECTION_PREFIX_LENGTH: usize = 3;
| ^^^^^^^^^ help: remove it
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self
= note: `#[warn(clippy::needless_pub_self)]` on by default
|
|
stable - x86_64-apple-darwin
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, Swatinem/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L530
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L533
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
|
|
stable - x86_64-apple-darwin
`ntex-amqp-codec` (lib) generated 2 warnings
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L672
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L672
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L675
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L675
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L685
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L685
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
stable - x86_64-apple-darwin:
codec/src/codec/decode.rs#L688
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
stable - x86_64-apple-darwin
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, Swatinem/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L530
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L533
use of deprecated method `chrono::TimeZone::timestamp`: use `timestamp_opt()` instead
|
|
nightly - x86_64-apple-darwin
`ntex-amqp-codec` (lib) generated 2 warnings
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L672
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L672
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L675
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L675
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L685
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L685
use of deprecated method `chrono::Date::<Tz>::and_hms_milli`: Use and_hms_milli_opt() instead
|
|
nightly - x86_64-apple-darwin:
codec/src/codec/decode.rs#L688
use of deprecated method `chrono::TimeZone::ymd`: use `with_ymd_and_hms()` instead
|