Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Ruby and docs dependencies to the latest versions #773

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

alexandrnikitin
Copy link
Member

This PR updates Ruby and docs dependencies to the latest versions. It also fixes some formatting issues in the docs. No visible difference with the current website.

Notes:

  • Some dependencies do not support latest (3.3 atm) Ruby version, so it's 3.2 so far.
  • Removes ruby_dep gem, not sure why it's needed.
  • Removes ruby from Gemlock's platforms, not sure what it is 😊 Tested on Windows using WSL.
  • Latest Jekyll doesn't highlight blocks with indentation, so explicit backquotes are needed.
  • This PR also replaces tabs with spaces to improve formatting, see screenshot below
Screenshot

chrome_F5zl94Cvf4

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexandrnikitin ! 🙇

Does the build still fail if the docs have an incorrect code snippet? If so then it is all set to merge 🎉

@alexandrnikitin
Copy link
Member Author

@dtchepak fixed the build. All is green now. Merging.

@alexandrnikitin alexandrnikitin merged commit e67780b into nsubstitute:main Jan 30, 2024
13 checks passed
@alexandrnikitin alexandrnikitin deleted the docs-update branch January 30, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants