compiler: Support slice expressions for string #3916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyfyrchik
force-pushed
the
compiler-substring
branch
3 times, most recently
from
78c1e8f to
b37dc02
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3916 +/- ##
==========================================
+ Coverage 81.78% 81.80% +0.02%
==========================================
Files 345 345
Lines 48852 48854 +2
==========================================
+ Hits 39954 39966 +12
+ Misses 7229 7222 -7
+ Partials 1669 1666 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
According to code, compiler currently supports slice expressions only for `[]byte` and triggers an error otherwise. However, using them with `string` type fails silently: ``` s := "abc" return s[:2] == "ab" // oops, false! ``` This happens, because the resulting type for this operation is `Buffer`, but "ab" has type `ByteString`. So, we have 2 options: - improve validation and trigger an error, - or just support strings. This commit implements the latter. Signed-off-by: Evgenii Stratonikov <[email protected]>
Otherwise, we get an error: ``` -: main module (github.com/nspcc-dev/neo-go) does not contain package github.com/nspcc-dev/neo-go/pkg/compiler ``` Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
fyfyrchik
force-pushed
the
compiler-substring
branch
from
b37dc02 to
5e0c961
Compare
|
Codecov failed because |
AnnaShaleva
approved these changes
May 29, 2025
There was a problem hiding this comment.
We may also improve https://github.com/nspcc-dev/neo-go/blob/master/docs/compiler.md#language-compatibility along the way.
AnnaShaleva
added
compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to code, compiler currently supports slice expressions only for
[]byteand triggers an error otherwise. However, using them withstringtype fails silently:This happens, because the resulting type for this operation is
Buffer, but "ab" has typeByteString. So, we have 2 options:This commit implements the latter.