Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Add new wallet constructors #3255

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

smallhive
Copy link
Contributor

Closes #3177

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (441eb8a) 85.26% compared to head (2012c56) 85.28%.
Report is 11 commits behind head on master.

Files Patch % Lines
pkg/wallet/wallet.go 53.84% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
+ Coverage   85.26%   85.28%   +0.01%     
==========================================
  Files         327      327              
  Lines       44144    44153       +9     
==========================================
+ Hits        37641    37656      +15     
+ Misses       5015     5005      -10     
- Partials     1488     1492       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/wallet/wallet.go Show resolved Hide resolved
pkg/wallet/wallet.go Outdated Show resolved Hide resolved
pkg/wallet/wallet.go Show resolved Hide resolved
@smallhive smallhive force-pushed the 3177-wallet-from-bytes branch 2 times, most recently from 2a879dc to 220450f Compare December 11, 2023 04:54
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

pkg/wallet/wallet.go Outdated Show resolved Hide resolved
pkg/wallet/wallet.go Outdated Show resolved Hide resolved
@smallhive smallhive force-pushed the 3177-wallet-from-bytes branch from 220450f to 2012c56 Compare December 12, 2023 04:34
@roman-khimov roman-khimov merged commit 3766206 into nspcc-dev:master Dec 14, 2023
17 of 19 checks passed
@smallhive smallhive deleted the 3177-wallet-from-bytes branch December 18, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NewWalletFromBytes function
3 participants