Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grimp.py small edits #781

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Update grimp.py small edits #781

merged 3 commits into from
Aug 24, 2023

Conversation

twilamoon-science
Copy link
Collaborator

changed a y to x and noted that vector layer is calculated by QGreenland Team.

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

changed a y to x and noted that vector layer is calculated by QGreenland Team.
@MattF-NSIDC
Copy link

MattF-NSIDC commented Aug 24, 2023

We really need self-serve config locking 😆

(#593)

Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs config lockfile update

@@ -84,7 +84,7 @@ def make_layer(
"title": "Annual ice sheet velocity magnitude 2021 (200m)",
},
"vx": {
"description": "Ice sheet velocity x component (vy) in meters per year for 2021."
"description": "Ice sheet velocity x component (vx) in meters per year for 2021."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@trey-stafford trey-stafford merged commit 40b0565 into main Aug 24, 2023
1 check passed
@trey-stafford trey-stafford deleted the twilamoon-science-patch-3 branch August 24, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants