Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERTED] Add logging #45

Merged
merged 10 commits into from
Jul 23, 2024
Merged

[REVERTED] Add logging #45

merged 10 commits into from
Jul 23, 2024

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Jul 23, 2024 •
edited
Loading

Replace printing with logging. Forbid print statements in the linter.

PR checklist
  • Has a descriptive title
  • Has a descriptive body
  • Includes a link to any issues closed by this PR, e.g. Closes #5.
  • Passes checks (to auto-fix a pre-commit.ci failure, add a comment
    containing "pre-commit.ci autofix")

@mfisher87 mfisher87 changed the base branch from main to v2 July 23, 2024 20:38
@mfisher87 mfisher87 marked this pull request as ready for review July 23, 2024 20:42
@mfisher87 mfisher87 merged commit aa3e53a into v2 Jul 23, 2024
3 checks passed
@mfisher87 mfisher87 deleted the no-print branch July 23, 2024 20:44
@mfisher87 mfisher87 restored the no-print branch July 23, 2024 20:45
@mfisher87
Copy link
Member Author

mfisher87 commented Jul 23, 2024 •
edited
Loading

Merged with the wrong branch and reversed the merge. Will do more PRs, please ignore this

@mfisher87 mfisher87 changed the title Add logging [REVERTED] Add logging Jul 23, 2024
@mfisher87 mfisher87 deleted the no-print branch July 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mfisher87