Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/29454/nx version resolve local dependency protocols #29455

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thdk
Copy link
Contributor

@thdk thdk commented Dec 21, 2024

Current Behavior

Local dependency protocols to link packages aren't resolved to the actual version for packages that aren't bumped during nx release version. Only packages that are bumped will have their local dependency protocol replaced.

Expected Behavior

All local dependency protocols should have been replaced in every package.json touched by the version command.

Related Issue(s)

Fixes #29454

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2024 7:17pm

Copy link

nx-cloud bot commented Dec 21, 2024

View your CI Pipeline Execution ↗ for commit 50fae0b.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 2m 10s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 22s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=c7e27... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-21 19:25:34 UTC

@thdk
Copy link
Contributor Author

thdk commented Dec 21, 2024

Draft PR, containing a test that shows the issue.

@thdk thdk force-pushed the feat/29454/nx-version-resolve-local-dependency-protocols branch from 5b9cab4 to 50fae0b Compare December 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nx release only replaces local dependency protocol with actual version for bumped packages
1 participant