Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add sync generators option to target defaults in nx-schema #29441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amrsalama
Copy link

Current Behavior

The JSON schema oftargetDefaults in nx.json doesn't accept syncGenerators even though it can be defined and NX respects it.

Expected Behavior

To be able to define default syncGenerators for targets in nx.json without schema violations.

@amrsalama amrsalama requested a review from a team as a code owner December 20, 2024 07:19
@amrsalama amrsalama requested a review from Cammisuli December 20, 2024 07:19
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 7:21am

Copy link

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit c3d843a.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 37m 19s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 6s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=efa5b... ✅ Succeeded 28s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 27s View ↗
nx documentation --no-dte ✅ Succeeded 1m 9s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 08:05:10 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant