feat(core): lock graph creation when running in another process #29408
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| use std::fs::{self, File}; | ||
| use std::io; | ||
| use std::path::Path; | ||
| use std::time::Duration; | ||
|
|
||
| #[napi] | ||
| #[derive(Clone)] | ||
| pub struct FileLock { | ||
| #[napi] | ||
| pub locked: bool, | ||
|
|
||
| lock_file_path: String, | ||
| } | ||
|
|
||
| #[napi] | ||
| impl FileLock { | ||
| #[napi(constructor)] | ||
| pub fn new(lock_file_path: String) -> Self { | ||
| let locked = Path::new(&lock_file_path).exists(); | ||
| Self { | ||
| locked, | ||
| lock_file_path, | ||
| } | ||
| } | ||
|
|
||
| #[napi] | ||
| pub fn lock(&mut self) -> anyhow::Result<()> { | ||
| if self.locked { | ||
| anyhow::bail!("File {} is already locked", self.lock_file_path) | ||
| } | ||
|
|
||
| let _ = File::create(&self.lock_file_path)?; | ||
| self.locked = true; | ||
| Ok(()) | ||
| } | ||
|
|
||
| #[napi] | ||
| pub fn unlock(&mut self) -> anyhow::Result<()> { | ||
| if !self.locked { | ||
| anyhow::bail!("File {} is not locked", self.lock_file_path) | ||
| } | ||
| fs::remove_file(&self.lock_file_path).or_else(|err| { | ||
| if err.kind() == io::ErrorKind::NotFound { | ||
| Ok(()) | ||
| } else { | ||
| Err(err) | ||
| } | ||
| })?; | ||
| self.locked = false; | ||
| Ok(()) | ||
| } | ||
|
|
||
| #[napi] | ||
| pub async fn wait(&self) -> Result<(), napi::Error> { | ||
| if !self.locked { | ||
| return Ok(()); | ||
| } | ||
|
|
||
| loop { | ||
| if !self.locked || !Path::new(&self.lock_file_path).exists() { | ||
| break Ok(()); | ||
| } | ||
| std::thread::sleep(Duration::from_millis(2)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Ensure the lock file is removed when the FileLock is dropped | ||
| impl Drop for FileLock { | ||
| fn drop(&mut self) { | ||
| if self.locked { | ||
| let _ = self.unlock(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { | ||
| use super::*; | ||
|
|
||
| use assert_fs::prelude::*; | ||
| use assert_fs::TempDir; | ||
|
|
||
| #[test] | ||
| fn test_new_lock() { | ||
| let tmp_dir = TempDir::new().unwrap(); | ||
| let lock_file = tmp_dir.child("test_lock_file"); | ||
| let lock_file_path = lock_file.path().to_path_buf(); | ||
| let lock_file_path_str = lock_file_path.into_os_string().into_string().unwrap(); | ||
| let mut file_lock = FileLock::new(lock_file_path_str); | ||
| assert_eq!(file_lock.locked, false); | ||
| let _ = file_lock.lock(); | ||
| assert_eq!(file_lock.locked, true); | ||
| assert!(lock_file.exists()); | ||
| let _ = file_lock.unlock(); | ||
| assert_eq!(lock_file.exists(), false); | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_wait() { | ||
| let tmp_dir = TempDir::new().unwrap(); | ||
| let lock_file = tmp_dir.child("test_lock_file"); | ||
| let lock_file_path = lock_file.path().to_path_buf(); | ||
| let lock_file_path_str = lock_file_path.into_os_string().into_string().unwrap(); | ||
| let mut file_lock = FileLock::new(lock_file_path_str); | ||
| let _ = file_lock.lock(); | ||
| let file_lock_clone = file_lock.clone(); | ||
| let wait_fut = async move { | ||
| let _ = file_lock_clone.wait().await; | ||
| }; | ||
| let _ = tokio::runtime::Runtime::new().unwrap().block_on(wait_fut); | ||
| assert_eq!(file_lock.locked, false); | ||
| assert_eq!(lock_file.exists(), false); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_drop() { | ||
| let tmp_dir = TempDir::new().unwrap(); | ||
| let lock_file = tmp_dir.child("test_lock_file"); | ||
| let lock_file_path = lock_file.path().to_path_buf(); | ||
| let lock_file_path_str = lock_file_path.into_os_string().into_string().unwrap(); | ||
| { | ||
| let mut file_lock = FileLock::new(lock_file_path_str.clone()); | ||
| let _ = file_lock.lock(); | ||
| } | ||
| assert_eq!(lock_file.exists(), false); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not need this