Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): create conformance rule recipe #29406

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Dec 18, 2024

Blocked until the create-rule generator is merged and released

@isaacplmann isaacplmann requested review from a team as code owners December 18, 2024 20:00
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 19, 2024 2:25pm

@isaacplmann isaacplmann added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Dec 18, 2024
@isaacplmann isaacplmann self-assigned this Dec 18, 2024
@isaacplmann isaacplmann requested review from JamesHenry and removed request for leosvelperez December 18, 2024 20:00
Copy link

nx-cloud bot commented Dec 18, 2024

View your CI Pipeline Execution ↗ for commit 6cddca6.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 3s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m View ↗
nx-cloud record -- nx format:check --base=0720f... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 13s View ↗
nx documentation --no-dte ✅ Succeeded 39s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 14:25:56 UTC

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the publish conformance rule guide to not repeat guidance on how to create and organize the rules, only add the publishing to it

@JamesHenry
Copy link
Collaborator

All the necessary pieces exist as of powerpack 1.1.1

@isaacplmann isaacplmann removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Jan 7, 2025
@isaacplmann isaacplmann merged commit 82751a1 into master Jan 7, 2025
6 of 7 checks passed
@isaacplmann isaacplmann deleted the docs/conformance-rule-recipe branch January 7, 2025 12:05
FrozenPandaz pushed a commit that referenced this pull request Jan 7, 2025
- [Create a Conformance
Rule](https://nx-dev-git-docs-conformance-rule-recipe-nrwl.vercel.app/nx-api/powerpack-conformance/documents/create-conformance-rule)
recipe

Blocked until the `create-rule` generator is merged and released

(cherry picked from commit 82751a1)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants