Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add prefixColor property to @nx:run-commands #29348

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nc1z
Copy link

@nc1z nc1z commented Dec 13, 2024

Current Behavior

Running tasks in parallel, we can set prefixes. However, there is no way to label our prefixes with colors. Currently the only way is to set the entire line to the color we want. This is not ideal as users may want to keep the default colors for the logs and only want to use the prefix colors as identifiers.

Expected Behavior

PR to add this option

Screenshots (Examples)

Tested with example screenshots below

Before (v20.2.2 latest release)

description

image

This PR (local release)

description

image

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 26, 2024 2:11am

Copy link

nx-cloud bot commented Dec 13, 2024

View your CI Pipeline Execution ↗ for commit 86fbdd3.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 33m 39s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 59s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=fbd3d... ✅ Succeeded 20s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 19s View ↗
nx documentation --no-dte ✅ Succeeded 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-26 02:47:24 UTC

@nc1z nc1z changed the title feat(core): add prefixColor property to run-commands feat(core): add prefixColor property to @nx:run-commands Dec 13, 2024
@nc1z nc1z force-pushed the feat/run-commands-prefix-color branch from 6404389 to a16f58c Compare December 13, 2024 16:41
@nc1z nc1z marked this pull request as ready for review December 13, 2024 16:41
@nc1z nc1z requested review from a team as code owners December 13, 2024 16:41
@nc1z
Copy link
Author

nc1z commented Dec 14, 2024

Update PR description with images tested with local release vs latest release.

Build/CI should pass once nx run e2e-release:e2e-ci--src/circular-dependencies.test.ts is fixed

Copy link

nx-cloud bot commented Dec 17, 2024

Your CI Pipeline Execution ↗ for commit b85afe1 is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 43m 35s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=ee4de... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 17s View ↗
nx documentation --no-dte ✅ Succeeded 1m 4s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-17 12:00:03 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants