Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: OpenAPI move-next-part add ignoreQuickLoop as optional attribute #1357

Merged

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Jan 9, 2025

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a feature

Current Behavior

the openAPI currently does not include the ignoreQuickLoop option in move-next-part

New Behavior

ignoreQuickLoop has been added as an optional attribute in move-next-part

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This affects only the openAPI

Time Frame

  • Not urgent, but we would like to get this merged into the in-development release.

Status

The addition has not been tested locally, as this requires java engine to be installed.

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@olzzon olzzon requested a review from a team as a code owner January 9, 2025 10:38
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.44%. Comparing base (b87cd9f) to head (cf72b49).
Report is 11 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/api/rest/v1/playlists.ts 0.00% 3 Missing ⚠️
meteor/server/lib/rest/v1/playlists.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1357      +/-   ##
=============================================
+ Coverage      55.71%   56.44%   +0.73%     
=============================================
  Files            384      401      +17     
  Lines          68508    72109    +3601     
  Branches        4203     4547     +344     
=============================================
+ Hits           38171    40705    +2534     
- Misses         30204    31155     +951     
- Partials         133      249     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit cb59dd9 into nrkno:release52 Jan 10, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants