[nrf noup] samples: code_relocation_nocopy: Support NS variant of nRF5340 DK #2545
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5340 DK Add Kconfig fragment that allows using the sample with the non-secure variant of the board. Applied as a noup because upstream the build fails on signing the image. Signed-off-by: Andrzej Głąbek <[email protected]>
anangl
force-pushed
the
code_relocation_nrf5340dk_ns
branch
from
7c01861 to
ca97fe7
Compare
SeppoTakalo
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
I would approve as [noup] because of following reasons:
- Split XIP build support only exist in NCS as a sysbuild scripts.
- Split XIP build requires PartitionManager which exist only in NCS.
- Our chip requires our fork of TF-M and all required pieces are in NCS.
Therefore TF-M build with all the required Partition Manager and Sysbuild support only exist in nRF Connect SDK. So this would not work on upstream.
|
I don't know what the intention is here but this does absolutely nothing for QSPI split image support, as can be seen by trying to build https://github.com/nrfconnect/sdk-nrf/tree/main/samples/nrf5340/extxip_smp_svr for an ns board target: All this does is allow a single sample to build which does not support updates in any way |
|
I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Kconfig fragment that allows using the sample with the non-secure variant of the board.
Applied as a noup because upstream the build fails on signing the image.