-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ncsdk 31820 fix failing arch tests #2540
Open
adamkondraciuk
wants to merge
2
commits into
nrfconnect:main
Choose a base branch
from
adamkondraciuk:NCSDK-31820-Fix-failing-arch-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ncsdk 31820 fix failing arch tests #2540
adamkondraciuk
wants to merge
2
commits into
nrfconnect:main
from
adamkondraciuk:NCSDK-31820-Fix-failing-arch-tests
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21f23af
to
ad388bf
Compare
kl-cruz
approved these changes
Feb 20, 2025
nordic-piks
approved these changes
Feb 21, 2025
mstasiaknordic
approved these changes
Feb 21, 2025
nordic-segl
approved these changes
Feb 21, 2025
kapi-no
reviewed
Feb 21, 2025
ad388bf
to
944f470
Compare
kapi-no
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I think you should also get a review from @doki-nordic who is the codeowner of the IPC service
kapi-no
reviewed
Feb 21, 2025
bb41167
to
bbdb7d3
Compare
Add `IPC_SERVICE_BACKEND_ICBMSG_EP_BOUND_WORK_Q_STACK_SIZE` config and parametrize its value depending on the optimization level. Upstream PR #: 86103 Signed-off-by: Adam Kondraciuk <[email protected]>
This reverts commit 28bd478. This commit can be reverted as the cause of test failure has been removed in ipc service by increasing workqueue stack size. Upstream PR #: 86103 Signed-off-by: Adam Kondraciuk <[email protected]>
bbdb7d3
to
ebcd37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing arm/arch tests for nRF54H20