-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] nrf54l15dk patches needed for run smp_svr (MCUboot & BLE DFU) #2026
Conversation
@@ -135,7 +135,7 @@ | |||
|
|||
mx25r64: mx25r6435f@0 { | |||
compatible = "jedec,spi-nor"; | |||
status = "okay"; | |||
status = "disabled"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mcu-tools/mcuboot@242db1a needs to be brought in as fromtree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i fallowed the pattern for other nordic DK devices. What you suggested caused build error on spi-nor driver, as expected spi00 driver is not there. PDK has this node disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other DK has this, the pdk is wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nrf52840dk, nrf5340dk, thingy53 - disabled(empty), nrf9161dk , nrf9151dk, nrf9131dk - disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to disable spi-nor driver thought Kconfig then (in a new mcuboot patch). @nordicjm Will be that fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For which board? nrf54l15dk is already disabled, if you mean nrf52840dk or nrf5340dk then they can be submitted upstream if needed, thingy53 should not be disabled because the secondary slot is in QSPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordicjm Removed the patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordicjm Can you approve?
a7c8423
to
5f51c69
Compare
d067d23
to
9824af7
Compare
While Partition Manager is enabled, it manages the offset by itself. Signed-off-by: Andrzej Puzdrowski <[email protected]>
9824af7
to
25e2785
Compare
No description provided.