[nrf fromlist] Bluetooth: ATT: lock scheduler when sending from user … #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread `att_req_send_process` is not thread safe. In the case where the current context is pre-emptible (e.g. when a user sends something over GATT from the main thread): The iterator in `att_req_send_process` can get interrupted mid-processing, breaking the logic and resulting in an assert/crash/data corruption. Additionally, the connection state check in this fn is also not thread-safe, the RX thread could pre-empt us and disconnect right before we attempt to send on an ATT bearer that is on it. This is a hotfix until we have a generalized solution for the host API surface. It seems a lot of our logic assumes cooperative priority. Upstream PR: zephyrproject-rtos/zephyr#69738 Signed-off-by: Jonathan Rico <[email protected]>
NordicBuilder
requested review from
asbjornsabo,
hermabe,
kruithofa and
theob-pro
alwa-nordic
approved these changes
Mar 4, 2024
martintv
approved these changes
Mar 4, 2024
laxiLang
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thread
att_req_send_processis not thread safe.In the case where the current context is pre-emptible (e.g. when a user sends something over GATT from the main thread):
The iterator in
att_req_send_processcan get interrupted mid-processing, breaking the logic and resulting in an assert/crash/data corruption.Additionally, the connection state check in this fn is also not thread-safe, the RX thread could pre-empt us and disconnect right before we attempt to send on an ATT bearer that is on it.
This is a hotfix until we have a generalized solution for the host API surface. It seems a lot of our logic assumes cooperative priority.
Upstream PR: zephyrproject-rtos/zephyr#69738