net: DHCPv4 server improvements #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only check if the address pool belongs to the same subnet as the server, but also that it does not overlap with the server address - otherwise the server might end up assigning its own address. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit a147ac9)
…addresses DHCPv4 server will send an ICMP probe (echo request) for the requested address before replying with DHCP Offer, unless probing is disabled in Kconfig. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 3c76ff9)
Upstream PR: zephyrproject-rtos/zephyr#68848 In case conflict is detected (either due to receiving Decline message or due to ICMP probe getting reply), the conflicting address becomes blocked for further use. Although the RFC is not specific about how long should the address be blocked, it make sense to implement some fallback mechanisms to reuse blocked addresses in the server, otherwise, after longer period of operation, it may run out of usable address. This commit adds a timeout for declined addresses, so that by default the address is marked back as "free" after 24 hrs (default lease time). It also implements a mechanism, which allows to re-use the oldest declined entry in case the server runs out of fresh addresses to assign. Signed-off-by: Robert Lubos <[email protected]>
…ions Upstream PR: zephyrproject-rtos/zephyr#68848 Apply ranges to DHCPv4 server timeout Kconfig options, so that it cannot be set to a negative value by mistake. Signed-off-by: Robert Lubos <[email protected]>
jukkar
approved these changes
Feb 14, 2024
SeppoTakalo
approved these changes
Feb 15, 2024
krish2718
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: NCSDK-25558
Jira: NCSDK-25559