Cherry pick 2024 02 12 #1495
Merged
Cherry pick 2024 02 12 #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
approved these changes
Feb 13, 2024
koffes
force-pushed
the
cherry-pick-2024-02-12
branch
from
2380bce to
0adc4c3
Compare
…start When CONFIG_BT_ISO_TEST_PARAMS is enabled then the bt_bap_broadcast_source_param in bt_cap_initiator_broadcast_audio_create had uninitialized values. A general and future proof solution for this is to simply initialize the entire struct to 0. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit f4b8341)
…tion fix Since we may go from enabling to qos-configured state if the call to bt_iso_big_create fails, that is a valid transition. If bt_iso_big_create currently fails, then the source ends in a state where it cannot be recovered. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 590d3e1)
…emove If the receive state is locally removed, then we should not request permission from the application, as that is implicit when removing the source locally. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 7643526)
…ive state The receive state may be added by the broadcast sink if not added by the application, but even in that case when the broadcast sink is deleted, we should not remove the receive state, as the receive state may still container information about the PA sync that has a lifetime not coupled with the broadcast sink. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 43bc320)
…sconnects When the CIS of a source ASE disconnects, the server shall put it into the QoS Configured state, which is not really part of the state machine for source ASEs, but more like a hidden bonus state change. The state machine handler in the unicast client has been updated to support this state change. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit b173c21)
…ected If we disconnect in the middle of e.g. a discovery, then client-busy (and other values) were not correctly reset, which effectively rendered the client useless. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 8b8569e)
…set_val The function did not move data correctly when increasing or decreasing the size of a value that was not the last value in the LTV array. Added a few tests to verify the fix, using the CCID list as the main way of verifying it. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 68f8c8f)
Moved seq_num check to after bt_iso_chan_send. This prevents WRN prints if ISO send fails. Signed-off-by: Kristoffer Rist Skøien <[email protected]> (cherry picked from commit ace435d)
This removes spurious error message printed when CIS has been disconnected and it was not used by any of the endpoints. This case is valid and may happen on Connection Timeout when the controller reports ACL Disconnection first. When the CIS Disconnection is reported after, the ASE is already in idle state and the referenece to CIS has been already removed (on ACL disconnection). Fixes: #64896 Signed-off-by: Mariusz Skamra <[email protected]> (cherry picked from commit b373079)
…a_len The length of the updated metadata was not updated. Fixes the CAP/INI/BST/BV-13-C test case. Signed-off-by: Magdalena Kasenberg <[email protected]> (cherry picked from commit e05d964)
The length check in ltv_set_val did not consider the size of the length or type fields. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit 234b322)
…econfig The stream_in_subgroup variable in bt_bap_broadcast_source_reconfig may have been uninitialized. Signed-off-by: Emil Gydesen <[email protected]> (cherry picked from commit f4cbf40)
koffes
force-pushed
the
cherry-pick-2024-02-12
branch
from
0adc4c3 to
bf10cae
Compare
alexsven
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.