[nrf noup] drivers: ieee802154: temporary fix for ACK header IE config #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejbaczmanski
force-pushed
the
ot_tmp_fix_rcp
branch
from
9391779 to
55f9558
Compare
maciejbaczmanski
force-pushed
the
ot_tmp_fix_rcp
branch
from
55f9558 to
039bb92
Compare
jciupis
approved these changes
Jan 12, 2024
Skip configuring ACK header IE if `EnableCsl()` has been called with arguments: - `aCslPeriod` == 0 - `aShortAddr` == IEEE802154_NO_SHORT_ADDRESS_ASSIGNED - `aExtAddr` == NULL This happens during RCP startup in `Radio::Init()` implementation. It will be fixed on OT and Zephyr level, but this commit is needed to prevent coprocessor samples from asserting on boot. Signed-off-by: Maciej Baczmanski <[email protected]>
maciejbaczmanski
force-pushed
the
ot_tmp_fix_rcp
branch
from
039bb92 to
d223cbb
Compare
canisLupus1313
approved these changes
Jan 12, 2024
carlescufi
approved these changes
Jan 12, 2024
rlubos
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip configuring ACK header IE if
EnableCsl()has been called with arguments:
aCslPeriod== 0aShortAddr== IEEE802154_NO_SHORT_ADDRESS_ASSIGNEDaExtAddr== NULLThis happens during RCP startup in
Radio::Init()implementation.It will be fixed on OT and Zephyr level, but this commit is needed
to prevent coprocessor samples from asserting on boot.