Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidewalk v1.18 #680

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Sidewalk v1.18 #680

merged 6 commits into from
Feb 24, 2025

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Feb 18, 2025 •
edited by totyz
Loading

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

ktaborowski and others added 5 commits February 18, 2025 10:12
@ktaborowski
libs: sidewalk 1.18 rc7
41471dc 
[KRKNWK-19824]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
pal: prevent for writing key id as a key
f8602fe 
Workaround for the issue with writing direct value
from storage to the key, by Sidewalk v1.18.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@RobertGalatNordic @ktaborowski
tests: update unit tests
d6b44ec 
update unit test

Signed-off-by: Robert Gałat <[email protected]>
@ktaborowski
pal: update subGHz config for Sidewalk 1.18
a328b44 
- Align seriabl bus header
- Align subGHz config

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
pal: remove not implemented callbacks
ec756c4 
Remove not implemented

Signed-off-by: Krzysztof Taborowski <[email protected]>
@github-actions github-actions bot added sid-lib PR changing Sidewalk libraries source PR changing src files tests labels Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

Sample diff used total
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 368 B 124.73 KB 0 B
ROM -6.3 KB 475.7 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 36 B 108.78 KB 0 B
ROM -4.55 KB 395.04 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 352 B 148.35 KB 0 B
ROM -7.49 KB 540.84 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 20 B 132.35 KB 0 B
ROM -5.71 KB 459.52 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 368 B 115.99 KB 0 B
ROM -6.29 KB 395.87 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 36 B 100.19 KB 0 B
ROM -4.52 KB 314.06 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 352 B 139.74 KB 0 B
ROM -7.49 KB 461.85 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.ble_only RAM 20 B 123.9 KB 0 B
ROM -5.71 KB 379.5 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 368 B 125.7 KB 0 B
ROM -7.78 KB 450.72 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 36 B 110.1 KB 0 B
ROM -6.02 KB 374.9 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 352 B 149.43 KB 0 B
ROM -8.97 KB 516.41 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 20 B 133.77 KB 0 B
ROM -7.2 KB 440.02 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 368 B 125.7 KB 0 B
ROM -7.78 KB 450.75 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 36 B 110.1 KB 0 B
ROM -6.02 KB 374.94 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 352 B 149.43 KB 0 B
ROM -8.97 KB 516.44 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 20 B 133.77 KB 0 B
ROM -7.2 KB 440.06 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 368 B 123.39 KB 0 B
ROM -6.3 KB 399.64 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 36 B 107.78 KB 0 B
ROM -4.54 KB 323.82 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 352 B 147.12 KB 0 B
ROM -7.49 KB 465.55 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM 20 B 131.46 KB 0 B
ROM -5.71 KB 389.18 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 352 B 148.33 KB 0 B
ROM -7.56 KB 532.24 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 352 B 125.94 KB 0 B
ROM -7.29 KB 490.08 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 36 B 98.61 KB 0 B
ROM -4.53 KB 393.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 352 B 139.73 KB 0 B
ROM -7.56 KB 454.34 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 352 B 117.47 KB 0 B
ROM -7.29 KB 410.52 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 36 B 90.28 KB 0 B
ROM -4.52 KB 312.62 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 352 B 149.42 KB 0 B
ROM -9.04 KB 508.69 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 352 B 127.13 KB 0 B
ROM -8.78 KB 465.09 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 36 B 100.14 KB 0 B
ROM -6 KB 373.22 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 352 B 149.42 KB 0 B
ROM -9.04 KB 508.72 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 352 B 127.13 KB 0 B
ROM -8.78 KB 465.13 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 36 B 100.14 KB 0 B
ROM -6 KB 373.25 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 352 B 147.12 KB 0 B
ROM -7.56 KB 462.78 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 352 B 124.82 KB 0 B
ROM -7.29 KB 414 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 36 B 97.83 KB 0 B
ROM -4.52 KB 322.14 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 36 B 93.81 KB 0 B
ROM -4.66 KB 323.01 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 368 B 109.77 KB 0 B
ROM -6.43 KB 400.15 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 36 B 85.66 KB 0 B
ROM -4.65 KB 240.98 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 368 B 101.46 KB 0 B
ROM -6.42 KB 318.92 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 36 B 95.51 KB 0 B
ROM -6.13 KB 300.72 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 368 B 111.12 KB 0 B
ROM -7.91 KB 374.68 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 36 B 95.51 KB 0 B
ROM -6.13 KB 300.75 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 368 B 111.12 KB 0 B
ROM -7.91 KB 374.71 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 36 B 93.2 KB 0 B
ROM -4.65 KB 250.57 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 368 B 108.81 KB 0 B
ROM -6.42 KB 324.54 KB 0 B

@totyz
doc: Update RAM and flash memory requirements
cddb84d 
Update memory requirements with values from 1.18 libs

Signed-off-by: Tomasz Tyzenhauz <[email protected]>
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 20, 2025
@ktaborowski ktaborowski merged commit d6a012c into nrfconnect:main Feb 24, 2025
48 checks passed
@ktaborowski ktaborowski mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@totyz totyz totyz approved these changes

@wojciechpluszynski wojciechpluszynski Awaiting requested review from wojciechpluszynski

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. func-integration sid-lib PR changing Sidewalk libraries source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaborowski @RobertGalatNordic @totyz