Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: fix log thread startup delay #679

Merged
merged 1 commit into from
Feb 13, 2025
Merged

log: fix log thread startup delay #679

merged 1 commit into from
Feb 13, 2025

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Feb 13, 2025 •
edited
Loading

remove thread strartup delay

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Feb 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 34 B 125.05 KB 0 B
ROM 2 B 462.58 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 34 B 110 KB 0 B
ROM 2 B 384.88 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 34 B 148.8 KB 0 B
ROM 2 B 529.49 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 34 B 133.69 KB 0 B
ROM 2 B 451.21 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 34 B 125.05 KB 0 B
ROM 2 B 462.61 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 34 B 110 KB 0 B
ROM 2 B 384.91 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 34 B 148.8 KB 0 B
ROM 2 B 529.53 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 34 B 133.69 KB 0 B
ROM 2 B 451.25 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 34 B 148.78 KB 0 B
ROM -2 B 521.84 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 34 B 126.49 KB 0 B
ROM 2 B 477.95 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 34 B 100.05 KB 0 B
ROM 2 B 383.18 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 34 B 148.78 KB 0 B
ROM -2 B 521.87 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 34 B 126.49 KB 0 B
ROM 2 B 477.99 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 34 B 100.05 KB 0 B
ROM 2 B 383.21 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 34 B 95.41 KB 0 B
ROM 2 B 310.36 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 34 B 110.47 KB 0 B
ROM -2 B 386.22 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 34 B 95.41 KB 0 B
ROM 2 B 310.39 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 34 B 110.47 KB 0 B
ROM -2 B 386.25 KB 0 B
.config diff 

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp_ns/zephyr/samples/sid_end_device/sample.sidewalk.dut.no_secure/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp_ns/zephyr/samples/sid_end_device/sample.sidewalk.dut.ble_only/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp_ns/zephyr/samples/sid_end_device/sample.sidewalk.dut/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l10_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.no_secure/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l10_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.ble_only/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l10_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.no_secure/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.ble_only/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf5340dk_nrf5340_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.no_secure/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut.ble_only/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf54l15dk_nrf54l15_cpuapp/zephyr/samples/sid_end_device/sample.sidewalk.dut/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/zephyr/samples/sid_end_device/sample.sidewalk.dut.no_secure/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/zephyr/samples/sid_end_device/sample.sidewalk.dut.ble_only/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

./sample-artifacts-meta/twister-out/nrf52840dk_nrf52840/zephyr/samples/sid_end_device/sample.sidewalk.dut/sid_end_device/zephyr/.config
old                                                           | new
CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=50		      |	CONFIG_LOG_PROCESS_THREAD_STARTUP_DELAY_MS=100

@RobertGalatNordic
log: increase log thread delay
95bff03 
current log thread delay is not sufficient
incerease to 100ms

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the fix_dut_boot_banner_missing branch from 200c05e to 95bff03 Compare February 13, 2025 08:34
@RobertGalatNordic RobertGalatNordic changed the title log: remove log thread startup delay log: fix log thread startup delay Feb 13, 2025
@totyz totyz merged commit adba7ad into nrfconnect:main Feb 13, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totyz totyz totyz approved these changes

Assignees
No one assigned
Labels
func-integration source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGalatNordic @totyz