Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare new test layout #660

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Prepare new test layout #660

merged 6 commits into from
Dec 16, 2024

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Dec 10, 2024 •
edited
Loading

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@ktaborowski
doc: document the way of testing
9d16395 
[KRKNWK-14886]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. source PR changing src files tests labels Dec 10, 2024
@RobertGalatNordic RobertGalatNordic force-pushed the prepare_new_test_layout branch 5 times, most recently from 9e7fa11 to 409e7c2 Compare December 10, 2024 16:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 0 B 144.62 KB 0 B
ROM 4 B 473.03 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.6 KB 0 B
ROM 4 B 378.44 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.29 KB 0 B
ROM 4 B 444.37 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 0 B 123.09 KB 0 B
ROM 4 B 471.49 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.64 KB 0 B
ROM 4 B 376.74 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM -109.44 KB 0 B 0 B
ROM -357.76 KB 0 B 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 0 B 131.98 KB 0 B
ROM 4 B 461.69 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 0 B 147.36 KB 0 B
ROM 4 B 536.24 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 124.97 KB 0 B
ROM 4 B 494.13 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 98.23 KB 0 B
ROM 4 B 394.68 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 0 B 114.87 KB 0 B
ROM 4 B 401.74 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 123.4 KB 0 B
ROM 4 B 384.37 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.6 KB 0 B
ROM 4 B 378.41 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.29 KB 0 B
ROM 4 B 444.34 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 0 B 123.09 KB 0 B
ROM 4 B 471.45 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.64 KB 0 B
ROM 4 B 376.71 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 0 B 120.87 KB 0 B
ROM 4 B 406.33 KB 0 B
nrf52840dk/nrf52840:sidewalk.test.simple_bootloader RAM 10.14 KB 10.14 KB 0 B
ROM 33.05 KB 33.05 KB 0 B
nrf5340dk/nrf5340/cpuapp:sidewalk.test.simple_bootloader RAM 10.29 KB 10.29 KB 0 B
ROM 35.39 KB 35.39 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sidewalk.test.simple_bootloader RAM 9.71 KB 9.71 KB 0 B
ROM 33.7 KB 33.7 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sidewalk.test.simple_bootloader RAM 9.71 KB 9.71 KB 0 B
ROM 33.72 KB 33.72 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sidewalk.test.simple_bootloader RAM 9.93 KB 9.93 KB 0 B
ROM 35.36 KB 35.36 KB 0 B

@RobertGalatNordic RobertGalatNordic force-pushed the prepare_new_test_layout branch 2 times, most recently from 9050c6d to 7e5042e Compare December 10, 2024 16:45
@RobertGalatNordic
GHA: add test_config and update GHA
dc4a486 
prepare gitHub automation for unit test refactoring

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
GHA: add cache
ebd9e5f 
restore ccache data before build

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
test: pal_delay
aaede1a 
add log to asserts

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
GHA: reduce number of subsets
89e202a 
after introduction to ccache, setup is now significant part of run
by increasing jobs on machine we increase value

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
Copy link
Collaborator Author

nrfconnect/sdk-nrf#19460

nrfconnect/sdk-zephyr#2363

ktaborowski
ktaborowski approved these changes Dec 13, 2024
View reviewed changes
.github/workflows/compare_config.yml
@@ -22,7 +22,7 @@ jobs:
diff_detected: ${{steps.config_diff.outputs.diff}}
artifact_url: ${{steps.save_diff.outputs.artifact-url}}

runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github made a warning that it will change the image under the latest variant to 24.04, so just to avoid wall of warnings, I manually set the version

test_config.yaml
Comment on lines +7 to +8
description: >
Prepare samples.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional to have a newline after the > ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the schema used in NRF test_config, so I just used the same format.

test_config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving to .github directory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only for github, IMO it should be at the root of the project

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used also for local manual builds, and it is easier to use test_config and some predefined level than long west command to build multiple samples

@RobertGalatNordic
test: revert change name of samples in testcase.yml
5391e16 
the test names are used by Jenkins.
They will be changed in other time

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic merged commit b56d926 into nrfconnect:main Dec 16, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktaborowski ktaborowski ktaborowski approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertGalatNordic @ktaborowski