Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: mcuboot upgrade only #647

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Nov 20, 2024

KRKNWK-18776

The configuration has been modified from SWAP_USING_MOVE to UPGRADE_ONLY.

We need to decide whether this change should be considered a workaround or a fix. Here are the key points to consider:

  • Performance: The bootloader with SWAP_USING_MOVE takes significantly longer on the nRF54 compared to the nRF52.
  • Security: The UPGRADE_ONLY configuration might be justified on the nRF54 as a security best practice.

Please review the change and provide your input on how we should classify this modification.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Sample diff used total

Memory usage did not change for any of the samples.

[KRKNWK-18776]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski changed the title samples: nrf54 mcuboot upgrade only samples: mcuboot upgrade only Nov 22, 2024
Clean up config options that are not used.

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18776]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 26, 2024
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ktaborowski ktaborowski merged commit 8e658e7 into nrfconnect:main Nov 26, 2024
56 of 57 checks passed
@ktaborowski ktaborowski deleted the boot_time_fix branch November 26, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants