Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krknwk 18969 update documentation for nrf54 #560

Merged
merged 2 commits into from
May 20, 2024
Merged

Krknwk 18969 update documentation for nrf54 #560

merged 2 commits into from
May 20, 2024

Conversation

RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented May 14, 2024 •
edited
Loading

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

KRKNWK-18969
KRKNWK-18982

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. source PR changing src files tests labels May 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

Sample diff used total

Memory usage did not change for any of the samples.

@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18969_update_documentation_for_nrf54 branch from 69de6cd to 8789157 Compare May 14, 2024 14:28
ktaborowski
ktaborowski requested changes May 15, 2024
View reviewed changes
annwoj
annwoj reviewed May 15, 2024
View reviewed changes
@RobertGalatNordic
test: disable failing test
69931ad 
KRKNWK-18969
KRKNWK-18982
on nrf54l15 this test fails randomly on different test cases.
temporary disable the execution for investigation.

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18969_update_documentation_for_nrf54 branch 2 times, most recently from fc27952 to 365fc7e Compare May 15, 2024 14:40
annwoj
annwoj reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@annwoj annwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some last small suggestions, thanks!

@RobertGalatNordic @annwoj
doc: Update nrf54 in doc
9a3a8b5 
KRKNWK-18969
Add gpio layout for nrf54 to doc

Signed-off-by: Robert Gałat <[email protected]>
Co-authored-by: Anna Wojdyło <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18969_update_documentation_for_nrf54 branch from 704bf6f to 9a3a8b5 Compare May 16, 2024 08:00
@RobertGalatNordic RobertGalatNordic requested a review from annwoj May 16, 2024 08:08
annwoj
annwoj approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@annwoj annwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@RobertGalatNordic RobertGalatNordic merged commit 3741bb0 into nrfconnect:main May 20, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktaborowski ktaborowski ktaborowski approved these changes

@totyz totyz totyz approved these changes

@annwoj annwoj annwoj approved these changes

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobertGalatNordic @ktaborowski @totyz @annwoj