Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: Add lcov as coverage tool in run_ut script #556

Merged
merged 1 commit into from
May 6, 2024
Merged

scripts: Add lcov as coverage tool in run_ut script #556

merged 1 commit into from
May 6, 2024

Conversation

totyz
Copy link
Contributor

@totyz totyz commented May 6, 2024 •
edited
Loading

Twister starts use gcov tool by default.
Switch back to lcov

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@totyz
scripts: Add lcov as coverage tool in run_ut script
69c6c9b 
Twister starts use gcov tool by default.
Switch back to lcov

Signed-off-by: Tomasz Tyzenhauz <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Sample diff used total

Memory usage did not change for any of the samples.

@totyz totyz requested a review from RobertGalatNordic May 6, 2024 13:39
RobertGalatNordic
RobertGalatNordic approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RobertGalatNordic RobertGalatNordic merged commit ac663c2 into nrfconnect:main May 6, 2024
44 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

Assignees
No one assigned
Labels
scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totyz @RobertGalatNordic