shell: replace log messages in on dev cert to shell print #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KRKNWK-18381 Because the shell is also responsible for handling log messages, it is impossible to do so while handling the shell command. This results in the delay between the creation of the log message inside the shell handler and its process and printing. Without this message the other side can not be sure if the command succeded, so it can not proced with next command wich causes significant delay. Now the shell printer is used to pass the messages from shell command and it does no go through logging system. Signed-off-by: Robert Gałat <[email protected]>
|
ktaborowski
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the shell is also responsible for handling log messages, it is impossible to do so while handling the shell command. This results in the delay between the creation of the log message inside the shell handler and its process and printing. Without this message the other side can not be sure if the command succeded, so it can not proced with next command wich causes significant delay.
Now the shell printer is used to pass the messages from shell command and it does no go through logging system.
CI parameters
(branch, hash, pull/XXX/head)
NRF_revision=main
manifest-pr-skip (remove this line to create PR in NRF)
Description
JIRA ticket: KRKNWK-18381
Detail description of the change
Self review