Add sysbuild configurations #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
.config diff.config change: https://github.com/nrfconnect/sdk-sidewalk/actions/runs/9155243484/artifacts/1518397503 Configuration diff too long to fit. Check file in artifacts. |
ktaborowski
force-pushed
the
sysbuild
branch
5 times, most recently
from
903bccc to
3f04dde
Compare
ktaborowski
force-pushed
the
sysbuild
branch
2 times, most recently
from
d34b0c6 to
988cac0
Compare
|
Manually tested:
|
6 tasks
ktaborowski
force-pushed
the
sysbuild
branch
3 times, most recently
from
0c70521 to
9e720eb
Compare
nordicjm
reviewed
Apr 23, 2024
samples/sid_end_device/sample.yaml
Outdated
| platform_allow: | ||
| - nrf52840dk_nrf52840 | ||
| - nrf5340dk_nrf5340_cpuapp | ||
| - nrf54l15pdk_nrf54l15_cpuapp | ||
| extra_args: | ||
| OVERLAY_CONFIG="overlay-demo.conf" |
There was a problem hiding this comment.
change to EXTRA_CONF_FILE
There was a problem hiding this comment.
Is OVERLAY_CONFIG deprecated? I see it in many samples and documentation articles
|
todo:
|
|
work in progress... |
need to enable some configs, but i found it in other samples, now it should be as before |
ktaborowski
commented
May 16, 2024
samples/sid_end_device/sysbuild/mcuboot/boards/nrf52840dk_nrf52840.overlay
Show resolved
Hide resolved
github-actions
bot
added
the
doc-required
nordicjm
reviewed
May 17, 2024
samples/sid_end_device/sysbuild/mcuboot/boards/nrf52840dk_nrf52840.overlay
Show resolved
Hide resolved
samples/sid_end_device/sysbuild/mcuboot/boards/nrf52840dk_nrf52840.overlay
Show resolved
Hide resolved
samples/sid_end_device/sysbuild/mcuboot/boards/nrf5340dk_nrf5340_cpuapp.overlay
Show resolved
Hide resolved
| # | ||
| # Copyright (c) 2024 Nordic Semiconductor ASA | ||
| # | ||
| # SPDX-License-Identifier: LicenseRef-Nordic-5-Clause |
There was a problem hiding this comment.
added .overlay with boot_partition
| # SPDX-License-Identifier: LicenseRef-Nordic-5-Clause | ||
| # | ||
|
|
||
| SB_CONFIG_PARTITION_MANAGER=n |
There was a problem hiding this comment.
this seems to conflict with the above file CONFIG_PARTITION_MANAGER_ENABLED=y?
There was a problem hiding this comment.
In this test application partition manager in not enabled
| # SPDX-License-Identifier: LicenseRef-Nordic-5-Clause | ||
| # | ||
|
|
||
| SB_CONFIG_PARTITION_MANAGER=n |
There was a problem hiding this comment.
In this test application partition manager in not enabled
ktaborowski
force-pushed
the
sysbuild
branch
3 times, most recently
from
b600698 to
1bba44e
Compare
totyz
approved these changes
May 20, 2024
[KRKNWK-18748] * add sysbuild config for sample * add sysbuild hci_ipc and mcuboot configs * use sysbuild in twister * use version file instead of script * replace deprecacet conf_file to new file_sufix Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18748] * use sysbuild to build functional and validation tests * do not use sysbuild in unit tests (not supported) * disable dfu and parition manager in tests Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18748] * align test with sample Signed-off-by: Krzysztof Taborowski <[email protected]>
nordicjm
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI parameters
NRF_revision=main
manifest-pr-skip (remove this line to create PR in NRF)
Description
JIRA ticket: KRKNWK-18781
Self review
CI parameters
(branch, hash, pull/XXX/head)
NRF_revision=main