Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: doc: post preview comment after build finishes #20610

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Feb 26, 2025

As of today, preview comment was published just after PR is posted, so if e.g. build fails, the comment may be misleading. Update the CI jobs to perform this in 2 steps, so that the docpublish workflow takes care of posting the comment.

@gmarull gmarull requested a review from a team as a code owner February 26, 2025 08:42
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20610/nrf/samples/wifi/radio_test/multi_domain/radio_test_subcommands.html

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 26, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: c402f0064ff8e759bf400fd7678af2cc1b13f972

more details

sdk-nrf:

PR head: c402f0064ff8e759bf400fd7678af2cc1b13f972
merge base: 444b6e0383ab83bd6036536e56be87f7d36b6e86
target head (main): b88c1413cdb6ccfbc3d06034c36249b34d92cccc
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
.github
│  ├── workflows
│  │  ├── docbuild.yml
│  │  ├── docpreview.yml
│  │  │ docpublish.yml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@gmarull gmarull force-pushed the doc-preview-post-build branch from a152838 to 83fd611 Compare February 26, 2025 09:24
@gmarull gmarull requested a review from umapraseeda February 26, 2025 09:29
As of today, preview comment was published just after PR is posted,
so if e.g. build fails, the comment may be misleading. Update the CI
jobs to perform this in 2 steps, so that the docpublish workflow takes
care of posting the comment.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull force-pushed the doc-preview-post-build branch from 83fd611 to c402f00 Compare February 26, 2025 10:03
@gmarull gmarull merged commit ee6552c into nrfconnect:main Feb 26, 2025
15 checks passed
@gmarull gmarull deleted the doc-preview-post-build branch February 26, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants