Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: nrf_profiler: Improve stats calculating script #20593

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MarekPieta
Copy link
Contributor

Change applies a series of improvements to the stats calculating script:

  • Clean up the script implementation
  • Allow defining presets using a *.json file
  • Add interval plot
  • Allow to filter outliers to improve UX

Change also adds a simple, predefined test preset for the nRF Desktop application.

Jira: NCSDK-31712

@MarekPieta MarekPieta requested a review from a team February 25, 2025 12:33
@MarekPieta MarekPieta requested a review from a team as a code owner February 25, 2025 12:33
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 25, 2025
@MarekPieta MarekPieta removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 25, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 25, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 40f0699c28a5f16e4558a27b25a3ce5ab4e849f3

more details

sdk-nrf:

PR head: 40f0699c28a5f16e4558a27b25a3ce5ab4e849f3
merge base: d974c7a051d2d4360218c8dbb3015009c884d31e
target head (main): c2e0a5880f68268b0974e7af56a65c40ee7de635
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
CODEOWNERS
scripts
│  ├── nrf_profiler
│  │  ├── calc_stats.py
│  │  ├── model_creator.py
│  │  ├── plot_nordic.py
│  │  ├── processed_events.py
│  │  ├── rtt2stream.py
│  │  ├── stats_nordic.py
│  │  ├── stats_nordic_presets
│  │  │  ├── nrf_desktop
│  │  │  │  │ hid_performance.json

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 29
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

kapi-no

This comment was marked as outdated.

@kapi-no kapi-no self-requested a review February 25, 2025 14:52
@MarekPieta MarekPieta force-pushed the profiler_stats_improve branch 2 times, most recently from 0838d48 to f9568f0 Compare February 25, 2025 15:29
Clean up the script implementation. Allow defining presets using a
*.json file. Allow to filter outliers to improve UX for histogram plot.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
Change introduces interval plot to the StatsNordic class.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
Change adds a simple test preset for nRF Desktop application. The test
preset allows to validate performance of HID data transmission.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
Change increases plot sizes to improve visibility.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
Change assigns maintainers to the nRF Profiler scripts.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
@MarekPieta MarekPieta force-pushed the profiler_stats_improve branch from f9568f0 to 3cb39ae Compare February 26, 2025 08:05
Copy link

@ablam ablam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments for this review are non-functional, consider applying them if additional time can be spend of further refactoring
except for that LGTM

@thst-nordic thst-nordic requested review from thst-nordic and removed request for NordicBuilder February 26, 2025 10:54
@thst-nordic
Copy link
Contributor

please ignore 'AI reviewer / review_full (pull_request) Failing'
It is a new action that needs a fix

Change updates the used logger names to avoid using spaces. The new
logger names match filenames.

Jira: NCSDK-31712

Signed-off-by: Marek Pieta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants