-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: nrf_profiler: Improve stats calculating script #20593
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 40f0699c28a5f16e4558a27b25a3ce5ab4e849f3 more detailssdk-nrf:
Github labels
List of changed files detected by CI (8)
Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
0838d48
to
f9568f0
Compare
Clean up the script implementation. Allow defining presets using a *.json file. Allow to filter outliers to improve UX for histogram plot. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
Change introduces interval plot to the StatsNordic class. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
Change adds a simple test preset for nRF Desktop application. The test preset allows to validate performance of HID data transmission. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
Change increases plot sizes to improve visibility. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
Change assigns maintainers to the nRF Profiler scripts. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
f9568f0
to
3cb39ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments for this review are non-functional, consider applying them if additional time can be spend of further refactoring
except for that LGTM
please ignore 'AI reviewer / review_full (pull_request) Failing' |
Change updates the used logger names to avoid using spaces. The new logger names match filenames. Jira: NCSDK-31712 Signed-off-by: Marek Pieta <[email protected]>
|
Change applies a series of improvements to the stats calculating script:
Change also adds a simple, predefined test preset for the nRF Desktop application.
Jira: NCSDK-31712