Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: benchmarks: multicore: Add synchronization between cores #20575

Conversation

nordic-segl
Copy link
Contributor

There is difference in boot time between Application and Radio cores.

When current consumption test is executed on two cores, synchronize their startup.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 24, 2025
Copy link

github-actions bot commented Feb 24, 2025

After documentation is built, you will find the preview for this PR here.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 13

Inputs:

Sources:

sdk-nrf: PR head: 20b1236ce84c19ddb56242ea7b2a9aba62a6a5f5

more details

sdk-nrf:

PR head: 20b1236ce84c19ddb56242ea7b2a9aba62a6a5f5
merge base: d37d9f680a97a36b568892180efd73847a8be268
target head (main): d37d9f680a97a36b568892180efd73847a8be268
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
tests
│  ├── benchmarks
│  │  ├── multicore
│  │  │  ├── idle_pwm_led
│  │  │  │  ├── remote
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── idle_pwm_loopback
│  │  │  │  ├── remote
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── idle_wdt
│  │  │  │  ├── remote
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── src
│  │  │  │  │  │ main.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-segl nordic-segl force-pushed the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch 7 times, most recently from 82fa69f to e24a977 Compare February 25, 2025 14:28
@nordic-segl nordic-segl marked this pull request as ready for review February 26, 2025 07:32
@nordic-segl nordic-segl requested review from a team as code owners February 26, 2025 07:32
@nordic-segl nordic-segl force-pushed the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch from e24a977 to d6e341a Compare February 26, 2025 07:32
@nordic-segl nordic-segl force-pushed the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch from d6e341a to bea500a Compare February 26, 2025 08:32
@nordic-segl nordic-segl force-pushed the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch from bea500a to 7ebb727 Compare February 26, 2025 11:36
Copy link

You can find the documentation preview for this PR here.

There is difference in boot time between Application and Radio cores.

When current consumption test is executed on two cores,
synchronize their startup.

Signed-off-by: Sebastian Głąb <[email protected]>
@nordic-segl nordic-segl force-pushed the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch from 7ebb727 to 20b1236 Compare February 26, 2025 12:30
@nordic-segl
Copy link
Contributor Author

It's passing in CI

12:44:39  INFO    - 1/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_wdt.nrf54h20dk_cpuapp_cpurad.idle PASSED (device: 001051180995, 36.395s <zephyr>)
12:44:39  INFO    -                                    benchmarks.multicore.idle_wdt.nrf54h20dk_cpuapp_cpurad.idle.test_measure_and_data_dump_pwm_and_idle PASSED
12:46:20  INFO    - 2/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_wdt.nrf54h20dk_cpuapp_cpurad.s2ram FAILED 1/1 pytest scenario(s) failed (device: 001051180995, 32.171s <zephyr>)
12:46:20  INFO    -                                    benchmarks.multicore.idle_wdt.nrf54h20dk_cpuapp_cpurad.s2ram.test_measure_and_data_dump_pwm_and_s2ram FAILED
<<< This is other issue not related to this PR >>>
12:47:47  INFO    - 3/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.idle PASSED (device: 001051100381, 32.265s <zephyr>)
12:47:47  INFO    -                                    benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.idle.test_measure_and_data_dump_pwm_and_idle PASSED
12:49:13  INFO    - 4/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_pwm_led.nrf54h20dk_cpuapp_cpurad.idle_fast PASSED (device: 001051100381, 31.557s <zephyr>)
12:49:13  INFO    -                                    benchmarks.multicore.idle_pwm_led.nrf54h20dk_cpuapp_cpurad.idle_fast.test_measure_and_data_dump_pwm_and_idle PASSED
12:50:43  INFO    - 5/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_pwm_led.nrf54h20dk_cpuapp_cpurad.idle PASSED (device: 001051100381, 31.438s <zephyr>)
12:50:43  INFO    -                                    benchmarks.multicore.idle_pwm_led.nrf54h20dk_cpuapp_cpurad.idle.test_measure_and_data_dump_pwm_and_idle PASSED
12:52:10  INFO    - 6/6 [email protected]/nrf54h20/cpuapp benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.idle_fast PASSED (device: 001051100381, 31.853s <zephyr>)
12:52:10  INFO    -                                    benchmarks.multicore.idle_pwm_loopback.nrf54h20dk_cpuapp_cpurad.idle_fast.test_measure_and_data_dump_pwm_and_idle PASSED

@rlubos rlubos merged commit 89ef021 into nrfconnect:main Feb 26, 2025
15 checks passed
@nordic-segl nordic-segl deleted the NRFX-7151_Synchronize-cores-in-current-consumption-tests branch February 26, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants