Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpsl: fem: add support for nrf21540_gpio for nrf54l #20273

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

ankuns
Copy link
Contributor

@ankuns ankuns commented Feb 10, 2025

This PR adds support for the nRF21540 Front-End Module in GPIO mode for the nRF54L Series devices.

Note: This PR contains only code related configuration and documentation. The core of the support is provided by MPSL. The MPSL is prvided by a separate PR.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 10, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 10, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: df5396212ad429e6a139518bf499d78137e5a911

more details

sdk-nrf:

PR head: df5396212ad429e6a139518bf499d78137e5a911
merge base: 27c5b09a927c01982c21553e683cbabb422aee80
target head (main): b92e9353a9d6defe98061d7fd6f54d42f61e691c
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── fem
│  │  │  │  │  ├── fem_nrf21540_gpio.rst
│  │  │  │  │  │ index.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
subsys
│  ├── mpsl
│  │  ├── fem
│  │  │  ├── Kconfig
│  │  │  ├── nrf21540_gpio
│  │  │  │  │ mpsl_fem_nrf21540_gpio.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 885
  • ✅ Integration tests
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@ankuns ankuns force-pushed the nrf21540_gpio_for_nrf54l branch from e2c485c to 4690ce4 Compare February 10, 2025 14:11
@ankuns ankuns added this to the 3.0.0 milestone Feb 10, 2025
@ankuns ankuns force-pushed the nrf21540_gpio_for_nrf54l branch from 4690ce4 to c921126 Compare February 11, 2025 09:22
The support for nRF21540 Front-End Module in GPIO mode that is
enabled by Kconfig option `CONFIG_MPSL_FEM_NRF21540_GPIO` is added.
This commit adds the code to configure the FEM. The remaining
support is provided by MPSL library in sdk-nrfxlib repository.

Signed-off-by: Andrzej Kuros <[email protected]>
@ankuns ankuns force-pushed the nrf21540_gpio_for_nrf54l branch from c921126 to 45e5950 Compare February 17, 2025 09:26
@ankuns ankuns marked this pull request as ready for review February 17, 2025 09:27
@ankuns ankuns requested review from a team and martintv as code owners February 17, 2025 09:27
@ankuns
Copy link
Contributor Author

ankuns commented Feb 17, 2025

@umapraseeda this is ready for final review

The documentation regarding nRF21540 in GPIO mode is updated to mention
support for the nRF54L SoCs.

Signed-off-by: Andrzej Kuros <[email protected]>
@ankuns ankuns force-pushed the nrf21540_gpio_for_nrf54l branch from 45e5950 to df53962 Compare February 17, 2025 11:09
@ankuns
Copy link
Contributor Author

ankuns commented Feb 17, 2025

@peknis I think I fixed all nits you pointed out

@peknis
Copy link
Contributor

peknis commented Feb 17, 2025

@peknis I think I fixed all nits you pointed out

Actually, there would be one more nit. In the description of the process of using the FEM in GPIO mode, the last two steps should have an imperative verb (do something). Otherwise, they are not proper steps.

@ankuns
Copy link
Contributor Author

ankuns commented Feb 17, 2025

I'm confused and don't understand what's wrong.
In the sentence about nRF53 the workd "must" is not imperative enough? The text has been there for a long time.
The step for nRF54L somehow complex, but it explains all the details that need to be taken into account.

@peknis
Copy link
Contributor

peknis commented Feb 17, 2025

I'm confused and don't understand what's wrong. In the sentence about nRF53 the workd "must" is not imperative enough? The text has been there for a long time. The step for nRF54L somehow complex, but it explains all the details that need to be taken into account.

There is a clear difference between "You must do this" and "Do this". I agree the previous step has been there a while, but now we have a chance to fix this.

@ankuns
Copy link
Contributor Author

ankuns commented Feb 17, 2025

Okay, I get it. If changing from "You must do this" to "do this" is the only issue, then what about merging it as it is and fixing the what you pointed out as a separate PR. The reason is that this pattern with "you must do..." is used among all FEMs and I would like to fix them in one PR which will follow shortly after this one. I would like to avoid fixing unrelated stuff in a PR which introduces an awaited feature.

@ankuns
Copy link
Contributor Author

ankuns commented Feb 17, 2025

It also seems that this piece of documentation has never appeared in our docs, as it is missing from app_dev/device_guides/fem/index.rst

https://ncsdoc.z6.web.core.windows.net/PR-20273/nrf/app_dev/device_guides/fem/index.html

image

@peknis
Copy link
Contributor

peknis commented Feb 17, 2025

My bad, I was looking in a wrong place. Ignore my comment. Let's do the wording improvements in a separate PR as you suggested.

@ankuns
Copy link
Contributor Author

ankuns commented Feb 18, 2025

@martintv @nrfconnect/ncs-co-build-system @nrfconnect/ncs-doc-leads kindly asking for approval.

@rlubos rlubos merged commit 2aa5697 into nrfconnect:main Feb 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants