applications: sdp: mspi: add calculating counter value #20209
+175
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: f7d8724ee6b7a54061d0496996395948a1b04bdf more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
from
0e04fa4 to
eb0a5a8
Compare
|
@magp-nordic CI is red |
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
from
eb0a5a8 to
8cb8290
Compare
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
from
8cb8290 to
c095118
Compare
|
After documentation is built, you will find the preview for this PR here. |
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
2 times, most recently
from
714e36a to
7d22dfc
Compare
masz-nordic
reviewed
Feb 26, 2025
drivers/mspi/mspi_nrfe.c
Outdated
Comment on lines
417
to
422
| if (SystemCoreClock % (cfg->freq * 2) != 0) { | ||
| LOG_ERR("Invalid frequency: %u. Only divisors of (CPU_FREQ / 2) are " | ||
| "allowed.", | ||
| cfg->freq); | ||
| return -EINVAL; | ||
| } |
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
from
7d22dfc to
429d26d
Compare
Add calculatng and setting VTIM top value based on desired transmission frequency. Signed-off-by: Magdalena Pastula <[email protected]>
Add checking if desired transmission frequency is possible to set. Signed-off-by: Magdalena Pastula <[email protected]>
Add temporary fix for not starting VTIM when max frequency is set (counter value 0). Signed-off-by: Magdalena Pastula <[email protected]>
magp-nordic
force-pushed
the
NRFX-6703-tx-timing-alignment-for-l15
branch
from
429d26d to
f7d8724
Compare
|
|
You can find the documentation preview for this PR here. |
masz-nordic
reviewed
Feb 26, 2025
| @@ -174,7 +199,7 @@ static void xfer_execute(nrfe_mspi_xfer_packet_msg_t *xfer_packet) | |||
| volatile nrfe_mspi_dev_config_t *device = | |||
| &nrfe_mspi_devices[nrfe_mspi_xfer_config_ptr->device_index]; | |||
|
|
|||
| xfer_params.counter_value = 4; | |||
| xfer_params.counter_value = cnt0_top_calculate(device->freq); | |||
There was a problem hiding this comment.
This should be done once, when NRFE_MSPI_CONFIG_DEV is received, and then cached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calculating VTIM CNT0 top value based on desired frequency.
Needs #20320 to make CI green.