Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: lte_link_control: Send NEIGHBOR_CELL_MEAS event in case of error #19844

Merged

Conversation

tokangas
Copy link
Contributor

@tokangas tokangas commented Jan 10, 2025

Earlier, no LTE_LC_EVT_NEIGHBOR_CELL_MEAS event was sent in case an error occurred during parsing of the %NCELLMEAS notification. Because of this, the user of the library did not have any way to determine when the operation had been completed. The implementation has been changed so, that an LTE_LC_EVT_NEIGHBOR_CELL_MEAS event is always sent, if lte_lc_neighbor_cell_measurement() has returned 0. In case of an error, an empty LTE_LC_EVT_NEIGHBOR_CELL_MEAS (current_cell set to LTE_LC_CELL_EUTRAN_ID_INVALID) is sent.

Removed Kconfig links from the library header. The reason behind the change is that Breathe is no longer used when generating the documentation, and without Breathe the links do not work and only cause the generated documentation to look bad.

@tokangas tokangas requested review from trantanen, jhirsi and a team as code owners January 10, 2025 11:52
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 10, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 10, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 1ca47de6a7507d9f2eb97cb02fd9dca0555a789b

more details

sdk-nrf:

PR head: 1ca47de6a7507d9f2eb97cb02fd9dca0555a789b
merge base: b65f69a952107a821e23c0a222a1d2545db8b437
target head (main): b65f69a952107a821e23c0a222a1d2545db8b437
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── modem
│  │  │ lte_lc.h
lib
│  ├── lte_link_control
│  │  ├── modules
│  │  │  │ ncellmeas.c
tests
│  ├── lib
│  │  ├── lte_lc_api
│  │  │  ├── src
│  │  │  │  │ lte_lc_api_test.c

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 367
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf-iot_lwm2m
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@tokangas tokangas force-pushed the lte_lc_send_ncellmeas_event_for_errors branch from b96ce30 to 1a86f28 Compare January 10, 2025 14:08
@tokangas tokangas force-pushed the lte_lc_send_ncellmeas_event_for_errors branch from 1a86f28 to 7d0d648 Compare January 10, 2025 14:55
@tokangas tokangas requested a review from a team as a code owner January 10, 2025 14:55
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 10, 2025
@tokangas tokangas force-pushed the lte_lc_send_ncellmeas_event_for_errors branch 2 times, most recently from 87c95a4 to 8e0c9db Compare January 14, 2025 13:46
@tokangas tokangas requested a review from peknis January 14, 2025 13:47
@tokangas
Copy link
Contributor Author

@peknis Added a new commit to remove the Kconfig links as discussed, please have a look.

Earlier, no LTE_LC_EVT_NEIGHBOR_CELL_MEAS event was sent in case an
error occurred during parsing of the %NCELLMEAS notification. Because
of this, the user of the library did not have any way to determine
when the operation had been completed. The implementation has been
changed so, that an LTE_LC_EVT_NEIGHBOR_CELL_MEAS event is always
sent, if lte_lc_neighbor_cell_measurement() has returned 0. In case
of an error, an empty LTE_LC_EVT_NEIGHBOR_CELL_MEAS (current_cell
set to LTE_LC_CELL_EUTRAN_ID_INVALID) is sent.

Signed-off-by: Tommi Kangas <[email protected]>
Removed Kconfig links from the library header. The reason behind
the change is that Breathe is no longer used when generating the
documentation, and without Breathe the links do not work and
only cause the generated documentation to look bad.

Signed-off-by: Tommi Kangas <[email protected]>
@tokangas tokangas force-pushed the lte_lc_send_ncellmeas_event_for_errors branch from 8e0c9db to 1ca47de Compare January 14, 2025 13:53
@tokangas tokangas changed the title lib: lte_link_control: Send NEIGHOR_CELL_MEAS event in case of error lib: lte_link_control: Send NEIGHBOR_CELL_MEAS event in case of error Jan 14, 2025
@nordicjm nordicjm merged commit d176b6b into nrfconnect:main Jan 15, 2025
13 checks passed
@tokangas tokangas deleted the lte_lc_send_ncellmeas_event_for_errors branch January 15, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants