-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: lte_link_control: Send NEIGHBOR_CELL_MEAS event in case of error #19844
lib: lte_link_control: Send NEIGHBOR_CELL_MEAS event in case of error #19844
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1ca47de6a7507d9f2eb97cb02fd9dca0555a789b more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)
Outputs:ToolchainVersion: 11349092be Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement!
b96ce30
to
1a86f28
Compare
1a86f28
to
7d0d648
Compare
87c95a4
to
8e0c9db
Compare
@peknis Added a new commit to remove the Kconfig links as discussed, please have a look. |
Earlier, no LTE_LC_EVT_NEIGHBOR_CELL_MEAS event was sent in case an error occurred during parsing of the %NCELLMEAS notification. Because of this, the user of the library did not have any way to determine when the operation had been completed. The implementation has been changed so, that an LTE_LC_EVT_NEIGHBOR_CELL_MEAS event is always sent, if lte_lc_neighbor_cell_measurement() has returned 0. In case of an error, an empty LTE_LC_EVT_NEIGHBOR_CELL_MEAS (current_cell set to LTE_LC_CELL_EUTRAN_ID_INVALID) is sent. Signed-off-by: Tommi Kangas <[email protected]>
Removed Kconfig links from the library header. The reason behind the change is that Breathe is no longer used when generating the documentation, and without Breathe the links do not work and only cause the generated documentation to look bad. Signed-off-by: Tommi Kangas <[email protected]>
8e0c9db
to
1ca47de
Compare
Earlier, no
LTE_LC_EVT_NEIGHBOR_CELL_MEAS
event was sent in case an error occurred during parsing of the%NCELLMEAS
notification. Because of this, the user of the library did not have any way to determine when the operation had been completed. The implementation has been changed so, that anLTE_LC_EVT_NEIGHBOR_CELL_MEAS
event is always sent, iflte_lc_neighbor_cell_measurement()
has returned0
. In case of an error, an emptyLTE_LC_EVT_NEIGHBOR_CELL_MEAS
(current_cell
set toLTE_LC_CELL_EUTRAN_ID_INVALID
) is sent.Removed Kconfig links from the library header. The reason behind the change is that Breathe is no longer used when generating the documentation, and without Breathe the links do not work and only cause the generated documentation to look bad.