Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: machine_learning: Update sample.yaml file #19249

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

maje-emb
Copy link
Contributor

@maje-emb maje-emb commented Dec 4, 2024

Added entry for the board nrf54l15dk/nrf54l15/cpuapp in the sample.yaml file.

@maje-emb maje-emb added this to the 2.9.0 milestone Dec 4, 2024
@maje-emb maje-emb requested a review from a team as a code owner December 4, 2024 11:20
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 4, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 3236eced05e75dd61dd03182bb13f53ba3a6612c

more details

sdk-nrf:

PR head: 3236eced05e75dd61dd03182bb13f53ba3a6612c
merge base: d126a9cb195cfad737b9f8bc5d4f9e0f8c3218e7
target head (main): b4851abf9b0a48c77b133768b1b7012ab15c09dd
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
applications
│  ├── machine_learning
│  │  │ sample.yaml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 57
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-apps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Just wanted to clarify: is it correct, that building for nrf54l15dk/nrf54l15/cpuapp will result in single-core configuration with simulated sensor? Then maybe nRF54L15 build should be mentioned in https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/applications/machine_learning/app_desc.html#nrf_machine_learning_build_types to make the table complete?

@maje-emb
Copy link
Contributor Author

maje-emb commented Dec 4, 2024

The change looks good. Just wanted to clarify: is it correct, that building for nrf54l15dk/nrf54l15/cpuapp will result in single-core configuration with simulated sensor? Then maybe nRF54L15 build should be mentioned in https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/applications/machine_learning/app_desc.html#nrf_machine_learning_build_types to make the table complete?

Yes, that's right, building for nrf54l15dk/nrf54l15/cpuapp will result in a single core configuration with a simulated sensor.
But this does not require additional configuration of prj_singlecore.conf. This is the default configuration from prj.conf.
So it seems to me that we don't need to update this table.

@shanthanordic shanthanordic self-requested a review December 4, 2024 13:57
@shanthanordic
Copy link

approved for scope

Added entry for the board `nrf54l15dk/nrf54l15/cpuapp`
in the sample.yaml file.

Ref: NCSDK-30382

Signed-off-by: Marcin Jelinski <[email protected]>
@jukkar jukkar merged commit 3d32533 into nrfconnect:main Dec 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants