Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: controller: Return an error if LLPM is not supported #18675

Merged
merged 2 commits into from
Dec 6, 2024
Merged

bluetooth: controller: Return an error if LLPM is not supported #18675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fc01f
bluetooth: controller: Allow enabling SDC LLPM on BabbleSim
MarekPieta Nov 19, 2024
3482082
bluetooth: controller: Return an error if LLPM is not supported
MarekPieta Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ Amazon Sidewalk
Bluetooth® LE
-------------

|no_changes_yet_note|
* Updated the Bluetooth LE SoftDevice Controller driver to make the :c:func:`hci_vs_sdc_llpm_mode_set` function return an error if Low Latency Packet Mode (LLPM) is not supported or not enabled in the Bluetooth LE Controller driver configuration (:kconfig:option:`CONFIG_BT_CTLR_SDC_LLPM`).

Bluetooth Mesh
--------------
Expand Down
3 changes: 2 additions & 1 deletion subsys/bluetooth/controller/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ config SYSTEM_WORKQUEUE_STACK_SIZE
config BT_CTLR_SDC_LLPM
bool "Enable Low Latency Packet Mode support"
select BT_CONN_PARAM_ANY if !BT_HCI_RAW
depends on (SOC_SERIES_NRF52X || SOC_SERIES_NRF54LX || SOC_SERIES_NRF54HX)
depends on (SOC_SERIES_NRF52X || SOC_SERIES_NRF54LX || SOC_SERIES_NRF54HX || \
SOC_SERIES_BSIM_NRF52X || SOC_SERIES_BSIM_NRF54LX)
help
Low Latency Packet Mode (LLPM) is a Nordic proprietary addition
which lets the application use connection intervals down to 1 ms.
Expand Down
4 changes: 4 additions & 0 deletions subsys/bluetooth/controller/hci_internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ static void vs_supported_commands(sdc_hci_vs_supported_vs_commands_t *cmds)
memset(cmds, 0, sizeof(*cmds));

cmds->read_supported_vs_commands = 1;
#if defined(CONFIG_BT_CTLR_SDC_LLPM)
cmds->llpm_mode_set = 1;
#endif
cmds->conn_update = 1;
cmds->conn_event_extend = 1;
cmds->qos_conn_event_report_enable = 1;
Expand Down Expand Up @@ -1681,8 +1683,10 @@ static uint8_t vs_cmd_put(uint8_t const *const cmd, uint8_t *const raw_event_out
*param_length_out += sizeof(sdc_hci_cmd_vs_read_supported_vs_commands_return_t);
vs_supported_commands((void *)event_out_params);
return 0;
#if CONFIG_BT_CTLR_SDC_LLPM
case SDC_HCI_OPCODE_CMD_VS_LLPM_MODE_SET:
return sdc_hci_cmd_vs_llpm_mode_set((void *)cmd_params);
#endif /* CONFIG_BT_CTLR_SDC_LLPM */
case SDC_HCI_OPCODE_CMD_VS_CONN_UPDATE:
return sdc_hci_cmd_vs_conn_update((void *)cmd_params);
case SDC_HCI_OPCODE_CMD_VS_CONN_EVENT_EXTEND:
Expand Down
Loading