-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_compress: Fix ARM thumb filter cross-chunk issue #18075
Conversation
nordicjm
commented
Oct 22, 2024
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: bb5b06c0512dee08bcffb97e1ed180d1084be0c8 more detailssdk-nrf:
mcuboot:
Github labels
List of changed files detected by CI (9)
Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
ed12049
to
dd5784f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test is failing: nrf/tests/subsys/nrf_compress/decompression/arm_thumb/src/main.c
Fixes an issue with the ARM thumb filter when an instruction crosses two chunks of data by storing bytes from the first for use in the second, this results in the output of the first run being less than the input data size and more than the input data size for the second run Signed-off-by: Jamie McCrae <[email protected]>
Update MCUboot to include fixes for ARM thumb filter usage Signed-off-by: Jamie McCrae <[email protected]>
Updates the test to support the new cross-chunk ARM thumb filter functionality, and verfies that the output size is the expected size Signed-off-by: Jamie McCrae <[email protected]>
dd5784f
to
bb5b06c
Compare
Fixed |
Including as part of #17567 |