samples: wifi: wfa_qt_app: Fix SVD failures #15427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hostap now uses more stack, so, calibrate and increase stack sizes. Fixes SHEL-2754. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
bama-nordic,
sachinthegreen,
krga2022,
D-Triveni,
Harini37 and
VivekUppunda
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
SachinDKulkarni
approved these changes
May 23, 2024
sachinthegreen
approved these changes
May 23, 2024
ioannisg
approved these changes
May 24, 2024
|
Side comment @krish2718 and @sachinthegreen : it would be nice if we could document (e.g. as part of the architecture documentation, SDK docs, etc.) which core threads are expected to invoke WPA supplicant calls, and hence are sensitive to the stack requirements of the hostap. This is very useful for application developers, so they can do proper selection of stack sizes. |
The memory for format is leaked. Instead of fixing the leak, move away from malloc based implementation it is overkill for logging and also protect the prints using a mutex, this should have been done even with malloc/free for thread safety (apart from inherent malloc/free thread safety). Fixes SHEL-2274. Signed-off-by: Chaitanya Tata <[email protected]>
The response handler doesn't check for failures and they will be ignored, add a check for failures and return failure. Signed-off-by: Chaitanya Tata <[email protected]>
Now that the memory leak has been fixed, we don't need 100K heap for QT app. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
requested review from
frkv,
Vge0rge,
vili-nordic,
SebastianBoe,
mswarowsky,
rado17,
rlubos,
plskeggs and
jayteemo
as code owners
krish2718
removed request for
a team,
plskeggs,
SebastianBoe,
jukkar,
lemrey,
jayteemo,
Vge0rge,
mswarowsky,
tejlmand,
carlescufi,
thst-nordic,
rlubos,
gmarull,
frkv,
glarsennordic and
vili-nordic
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
krish2718
changed the title
D-Triveni
approved these changes
May 29, 2024
bama-nordic
approved these changes
May 29, 2024
Fixes heap corruption seen in SVD test suites. Signed-off-by: Chaitanya Tata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hostap now uses more stack, so, calibrate and increase stack sizes.
Fixes SHEL-2754.