Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf_security: cracen: Fix configuration system #14323

Merged
merged 6 commits into from
Mar 14, 2024
Merged

nrf_security: cracen: Fix configuration system #14323

merged 6 commits into from
Mar 14, 2024

Conversation

mswarowsky
Copy link
Contributor

@mswarowsky mswarowsky commented Mar 1, 2024 •
edited by stephen-nordic
Loading

The CRACEN configuration system wasn't working with oberon core 1.2.1.1 As the key management changed, this fixed that for CRACEN

test_crypto: PR-609

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 1, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 4, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@aa2eeb1 nrfconnect/sdk-zephyr@ecb16c7 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@mswarowsky mswarowsky added the Platform: nRF54L PRs specific to nRF54L platform that can be merged during stabilization period. label Mar 5, 2024
@mswarowsky mswarowsky force-pushed the cracen_config branch 2 times, most recently from bc72cab to e9ade7e Compare March 5, 2024 09:22
@mswarowsky mswarowsky marked this pull request as ready for review March 5, 2024 09:28
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 5, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

SebastianBoe
SebastianBoe requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@SebastianBoe SebastianBoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a first review pass, but if you don't mind, I would like to review after we have a green CI :)

@mswarowsky mswarowsky requested a review from SebastianBoe March 5, 2024 14:34
@github-actions github-actions bot removed the manifest label Mar 5, 2024
@mswarowsky mswarowsky force-pushed the cracen_config branch 2 times, most recently from 3a5fe0a to 2f3dba6 Compare March 7, 2024 09:07
@mswarowsky mswarowsky requested a review from Vge0rge March 11, 2024 11:09
@mswarowsky mswarowsky force-pushed the cracen_config branch 2 times, most recently from 8c73702 to dae9ac1 Compare March 14, 2024 12:28
@mswarowsky
Revert "cracen: Enable CONFIG_PSA_ACCEL for everything"
a540464 
This reverts commit 7d1fb3c.

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky
nrf_security: cracen: Fix configuration system
6c6c27f 
The CRACEN configuration system wasn't working with oberon core 1.2.1.1
As the key management changed, this fixed that for CRACEN

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky
nrf_security: cracen: Move PSA_WANT_ALG_SP800_108_COUNTER_CMAC
d05a0a6 
This kconfig should be part of zephyr/modules/mbedtls/Kconfig.psa
and not in the cracen Kconfig so removing it here to add it to zephyr

Ref: NCSDK-26142

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky
samples: rsa: Fix log messages
2cd8e87 
After the sample was changed to import keys instead of generating them
the log messages were not all changed

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky
nrf_security: cracen: Make PAKE context configurable
13f9bd0 
Only add the context of enabled algorithms, this saves space as the SRP
context is more than twice as big as the jpake ctx

Signed-off-by: Markus Swarowsky <[email protected]>
@mswarowsky
samples: ecjpake: Fix PSA_WANT config
22837b2 
Add missing CONFIG_PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY=y

Signed-off-by: Markus Swarowsky <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Mar 14, 2024
@carlescufi carlescufi merged commit 2ffa765 into nrfconnect:main Mar 14, 2024
13 of 14 checks passed
@jciupis jciupis mentioned this pull request Mar 15, 2024
Closed
@mswarowsky mswarowsky deleted the cracen_config branch April 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianBoe SebastianBoe SebastianBoe approved these changes

@magnev magnev magnev approved these changes

@Vge0rge Vge0rge Vge0rge approved these changes

@frkv frkv Awaiting requested review from frkv

@vili-nordic vili-nordic Awaiting requested review from vili-nordic

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-zephyr Platform: nRF54L PRs specific to nRF54L platform that can be merged during stabilization period.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mswarowsky @NordicBuilder @SebastianBoe @magnev @Vge0rge @carlescufi