wifi: Add 54h support #14047
Merged
wifi: Add 54h support #14047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
sachinthegreen,
rado17 and
rlubos
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
krish2718
force-pushed
the
add_54h_support
branch
from
061f43b to
86f45cd
Compare
sachinthegreen
requested changes
Feb 16, 2024
samples/wifi/shell/boards/nrf54h20dk_nrf54h20_cpuapp_soc1.overlay
Outdated
Show resolved
Hide resolved
krish2718
force-pushed
the
add_54h_support
branch
from
86f45cd to
94df2b2
Compare
github-actions
bot
added
doc-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
krish2718
force-pushed
the
add_54h_support
branch
from
94df2b2 to
b0f93db
Compare
gmarull
requested changes
Feb 16, 2024
samples/wifi/shell/boards/nrf54h20dk_nrf54h20_cpuapp_soc1.overlay
Outdated
Show resolved
Hide resolved
samples/wifi/shell/boards/nrf54h20dk_nrf54h20_cpuapp_soc1.overlay
Outdated
Show resolved
Hide resolved
sachinthegreen
approved these changes
Feb 19, 2024
krish2718
added
the
Platform: nRF54H
krish2718
force-pushed
the
add_54h_support
branch
from
b0f93db to
568473e
Compare
github-actions
bot
removed
doc-required
krish2718
force-pushed
the
add_54h_support
branch
4 times, most recently
from
bbd0390 to
a8b2fd6
Compare
krish2718
force-pushed
the
add_54h_support
branch
from
74ff3be to
40bbd0b
Compare
|
@gmarull please re-review. |
gmarull
reviewed
Apr 11, 2024
krish2718
force-pushed
the
add_54h_support
branch
from
40bbd0b to
55aa64b
Compare
krish2718
force-pushed
the
add_54h_support
branch
2 times, most recently
from
965c920 to
8ab0728
Compare
gmarull
reviewed
Apr 18, 2024
krish2718
force-pushed
the
add_54h_support
branch
from
8ab0728 to
e3b9846
Compare
|
Wi-Fi association and ping are working with manually wiring up the nRF7002 EK. |
gmarull
reviewed
May 3, 2024
| }; | ||
| }; | ||
|
|
||
| /* Below sections are unchanged, duplicated as delete the entire node */ |
There was a problem hiding this comment.
why is entire-node deletion required?
There was a problem hiding this comment.
The starting region is the CPU app and as we change the size all other regions have to be adjusted and for Wi-Fi we don't use those regions, so, instead of adjusting the node, deleted the node and only kept the relevant regions. I could delete all unused regions, but if an another region is added in the future, this will break, so, it's better to delete the full node.
Comment on lines
+15
to
+17
| /delete-node/ &cpuppr_vpr; | ||
| /delete-node/ &mram1x; | ||
| /delete-node/ &cpurad_uicr; |
There was a problem hiding this comment.
why are we deleting stuff like ppr vpr node here?
There was a problem hiding this comment.
it's not needed for Wi-Fi.
|
|
||
| chosen { | ||
| zephyr,wifi = &nordic_wlan0; | ||
| zephyr,bt-hci-ipc = ""; |
There was a problem hiding this comment.
As we had deleted the unnecessary IPC regions above, this was needed for build.
busineni
approved these changes
May 3, 2024
* This uses SPIM130 on Port 2 and few GPIOs to communicate with nRF7002 EK. * Extends Flash to 1M and RAM to 512K by redefining the memory layout - IPC support isn't added yet Implements SHEL-2610. Signed-off-by: Chaitanya Tata <[email protected]>
nRF54H doesn't support nRFx clock, so, protect with the proper define. Signed-off-by: Chaitanya Tata <[email protected]>
This adds nRF54H20DK with nRF7002 EK combination which is now supported. Implements SHEL-2610. Signed-off-by: Chaitanya Tata <[email protected]>
gmarull
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested Wi-Fi open association and ping.